Improve test assertion

thomhurst · Aug 28, 2024 · 8ddce91 · 8ddce91
1 parent 9670b04
commit 8ddce91
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/test/ModularPipelines.UnitTests/NotInParallelTests.cs b/test/ModularPipelines.UnitTests/NotInParallelTests.cs
@@ -5,6 +5,7 @@
 
 namespace ModularPipelines.UnitTests;
 
+[Retry(3)]
 public class NotInParallelTests
 {
     [ModularPipelines.Attributes.NotInParallel]
@@ -58,7 +59,7 @@ public class NotParallelModuleWithNonParallelDependency : Module<string>
         }
     }
 
-    [Test, Retry(3)]
+    [Test]
     public async Task NotInParallel()
     {
         var results = await TestPipelineHostBuilder.Create()
@@ -69,11 +70,10 @@ public async Task NotInParallel()
         var firstModule = results.Modules.MinBy(x => x.EndTime)!;
         var nextModule = results.Modules.MaxBy(x => x.EndTime)!;
         await Assert.That(nextModule.StartTime)
-            .Is.EqualToWithTolerance(firstModule.StartTime + TimeSpan.FromSeconds(5),
-                TimeSpan.FromSeconds(1));
+            .Is.GreaterThanOrEqualTo(firstModule.StartTime + TimeSpan.FromSeconds(5));
     }
 
-    [Test, Retry(3)]
+    [Test]
     public async Task NotInParallel_With_ParallelDependency()
     {
         var results = await TestPipelineHostBuilder.Create()
@@ -84,10 +84,10 @@ public async Task NotInParallel_With_ParallelDependency()
         var firstModule = results.Modules.MinBy(x => x.EndTime)!;
         var nextModule = results.Modules.MaxBy(x => x.EndTime)!;
         await Assert.That(nextModule.StartTime)
-            .Is.EqualToWithTolerance(firstModule.StartTime + TimeSpan.FromSeconds(5), TimeSpan.FromSeconds(1));
+            .Is.GreaterThanOrEqualTo(firstModule.StartTime + TimeSpan.FromSeconds(5));
     }
 
-    [Test, Retry(3)]
+    [Test]
     public async Task NotInParallel_With_NonParallelDependency()
     {
         var results = await TestPipelineHostBuilder.Create()
@@ -102,6 +102,6 @@ public async Task NotInParallel_With_NonParallelDependency()
         var expectedStartTime = firstModule.StartTime + TimeSpan.FromSeconds(10);
 
         await Assert.That(nextModule.StartTime)
-            .Is.EqualToWithTolerance(expectedStartTime, TimeSpan.FromSeconds(1));
+            .Is.GreaterThanOrEqualTo(expectedStartTime);
     }
 }
diff --git a/test/ModularPipelines.UnitTests/ParallelLimiterTests.cs b/test/ModularPipelines.UnitTests/ParallelLimiterTests.cs
@@ -5,6 +5,7 @@
 
 namespace ModularPipelines.UnitTests;
 
+[Retry(3)]
 public class ParallelLimiterTests
 {
     [ModularPipelines.Attributes.ParallelLimiter<MyParallelLimit>]
@@ -68,7 +69,7 @@ public class Module6 : Module<string>
         }
     }
 
-    [Test, Repeat(3)]
+    [Test]
     public async Task LimitParallel()
     {
         var results = await TestPipelineHostBuilder.Create()