Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework add_guides for arbitrary guide positions #339

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

teunbrand
Copy link
Contributor

This PR updates patchwork to deal with tidyverse/ggplot2#5488.

Briefly, if tidyverse/ggplot2#5488 gets merged, guides will always have 5 positions in the gtable for left, right, top, bottom and inside positions. This eliminates the need for {patchwork} to work in missing rows/columns of the gtable. Collecting guides from a gtable on the other hand, requires grabbing the guides from 5 guide-boxes instead of 1.

Some visual tests changed at the svg level due to some slight rounding changes, but for humans they look exactly the same. This isn't a consequence of this PR, but of changes in the dev version of ggplot2. Hence, I didn't include those snapshot changes.

@teunbrand teunbrand marked this pull request as draft November 25, 2023 14:11
@teunbrand teunbrand marked this pull request as ready for review December 8, 2023 10:38
@teunbrand
Copy link
Contributor Author

@thomasp85 This is a kind reminder that it would be swell to merge this in before ggplot2 3.5.0 is released.

@thomasp85 thomasp85 merged commit 0033fc0 into thomasp85:main Jan 4, 2024
14 checks passed
@thomasp85
Copy link
Owner

Thanks!

@teunbrand teunbrand deleted the guide_position_update branch January 4, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants