Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add middlewares for cozy filtering and logging #71

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

EvgenyOvsov
Copy link
Contributor

Hi.
For my cases, I need to filter requests or analyze it in any way, so I decided to add middleware in your socks server

@EvgenyOvsov EvgenyOvsov force-pushed the add_middlewares branch 2 times, most recently from a9fc8aa to 7bf05a8 Compare August 31, 2024 16:34
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 66.66%. Comparing base (8de715f) to head (ebe069a).
Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
handle.go 64.28% 5 Missing ⚠️
option.go 68.75% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   63.13%   66.66%   +3.52%     
==========================================
  Files          14       14              
  Lines         784      726      -58     
==========================================
- Hits          495      484      -11     
+ Misses        230      184      -46     
+ Partials       59       58       -1     
Flag Coverage Δ
unittests 66.66% <66.66%> (+3.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thinkgos
Copy link
Member

thinkgos commented Sep 3, 2024

Hi, if i set custom user's handle, the middlewares no effect, Can you modify this!

@EvgenyOvsov
Copy link
Contributor Author

Yeah, sorry, my fault. Fixed

@thinkgos thinkgos merged commit ad9f2cf into things-go:master Sep 6, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants