Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzer cleanup #9527

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Fuzzer cleanup #9527

merged 2 commits into from
Oct 2, 2024

Conversation

cujomalainey
Copy link
Member

  • Delete old fuzzer code
  • Fix overflow in posix fuzzers

All fuzzing infra has moved to the posix platform. The corpus is not
being deployed, and is soon to be modified anyways. Its also missing
IPC4 in the corpus.

Signed-off-by: Curtis Malainey <[email protected]>
@lgirdwood
Copy link
Member

@ranj063 pls review.

Copy link
Contributor

@andyross andyross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whine about verbosity, but looks good here

src/platform/posix/ipc.c Show resolved Hide resolved
Fix silent overflow in the fuzzer. 255 is clearly << 65536 so that means
we are not able to exercise the full buffer. But upon further inspection
its clear that numbers are a minimum truncated if not rolling over based
on the code in the size_t to uint8_t conversions.

This was validated by converting the type temporarily to signed and
observing the fuzzer using a negative index.

Signed-off-by: Curtis Malainey <[email protected]>
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go once CI runs complete.

@lgirdwood lgirdwood merged commit a9481c6 into thesofproject:main Oct 2, 2024
44 of 47 checks passed
@cujomalainey cujomalainey deleted the fuzz branch October 2, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants