ipc/cmake: use the new add_local_sources() indirection layer #8549
Conversation
marc-hb
requested review from
bardliao,
marcinszkudlinski,
pblaszko,
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
|
SOFCI TEST |
|
There's apparently a new MTL firmware needed: Does not seem to impact other test results, everything else is green. https://sof-ci.01.org/sofpr/PR8549/build581/devicetest/index.html and https://sof-ci.01.org/sof-pr-viewer/#/build/PR8549/build13196789 is all green too. cc: @kv2019i , @keqiaozhang |
It runs to a new error after downloading the missing i915 firmware. https://anduin.linuxfromscratch.org/sources/linux-firmware/i915/mtl_gsc_1.bin |
|
Ready to be merged except for mandatory CI. "Internal Intel CI System/merge/codecheck" seems to be stuck. |
In the review of commit 1bd9e0d ("cmake/zephyr: decentralize src/ipc/"), Andy recommended "maybe work around this by adding yet another layer of indirection". I rejected the idea at the time because the level of duplication in the ipc/ directory was small. Then I looked at the bigger math/ subdirectory and I realized in thesofproject#8548 that such an indirection layer is actually required for bigger and/or more complex cases. So I added that layer of indirection in commit 330d73e ("cmake: a few new add_local_sources[_ifdef]() compatibility macros") Now that we have it, we might as well use it and perform small simplifications in ipc/cmake. Signed-off-by: Marc Herbert <[email protected]>
marc-hb
force-pushed
the
cmake-ipc-indirection
branch
from
efbe978
to
6b64cfe
Compare
Re-run thanks to an empty Well known MTL GSC firmware issue in https://sof-ci.01.org/sofpr/PR8549/build735/devicetest/index.html, everything else passed (even suspend/resume!) Only one suspend/resume failure in |
In the review of commit 1bd9e0d ("cmake/zephyr: decentralize src/ipc/"), Andy recommended "maybe work around this by adding yet another layer of indirection". I rejected the idea at the time because the level of duplication in the ipc/ directory was small. Then I looked at the bigger math/ subdirectory and I realized in #8548 that such an indirection layer is actually required for bigger and/or more complex cases. So I added that layer of indirection in commit 330d73e ("cmake: a few new add_local_sources_ifdef compatibility macros")
Now that we have it, we might as well use it and perform small simplifications in ipc/cmake.