Fix compilation errors / warnings #8547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 16d126a ("audio: Header files cleanup") removed rtos/panic.h include but this is still needed. Otherwise, we get the following compilation error: /work/repos/sof/src/lib/lib.c: In function ‘memset’: /work/repos/sof/src/lib/lib.c:31: warning: implicit declaration of function ‘sof_panic’ Fixes: 16d126a ("audio: Header files cleanup") Signed-off-by: Daniel Baluta <[email protected]>
dbaluta
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej and
kv2019i
as code owners
This fixes following compilation warnings: repos/sof/src/audio/drc/drc_hifi4.c: In function ‘drc_delay_input_sample_s16’: repos/sof/src/audio/drc/drc_hifi4.c:580: warning: assignment from incompatible pointer type repos/sof/src/audio/drc/drc_hifi4.c:581: warning: assignment from incompatible pointer type repos/sof/src/audio/drc/drc_hifi4.c: In function ‘drc_delay_input_sample_s32’: repos/sof/src/audio/drc/drc_hifi4.c:718: warning: assignment from incompatible pointer type repos/sof/src/audio/drc/drc_hifi4.c:719: warning: assignment from incompatible pointer type Signed-off-by: Daniel Baluta <[email protected]>
kv2019i
approved these changes
Nov 28, 2023
dbaluta
changed the title
iuliana-prodan
approved these changes
Nov 28, 2023
cujomalainey
approved these changes
Nov 29, 2023
btian1
approved these changes
Nov 29, 2023
pjdobrowolski
approved these changes
Nov 29, 2023
|
SOFCI TEST |
softwarecki
approved these changes
Nov 29, 2023
|
@lgirdwood good to merge. CI is stuck :( (sof-ci/jenkins/pr-build ) |
lgirdwood
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 16d126a ("audio: Header files cleanup") removed rtos/panic.h include but this is still needed.
Otherwise, we get the following compilation error:
/work/repos/sof/src/lib/lib.c: In function ‘memset’:
/work/repos/sof/src/lib/lib.c:31: warning: implicit declaration of function ‘sof_panic’
Fixes: 16d126a ("audio: Header files cleanup")