lmdk: dwmix: Add example of loadable down mixer module #8546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ported additional error code definitions from iadk module API. These codes are not unique and their meaning depends on the context / which function returns it. Signed-off-by: Adrian Warecki <[email protected]>
The example of down mixer module ported from iadk. Its build as a native loadable sof module. Signed-off-by: Adrian Warecki <[email protected]>
The API version used by the module is defined in the module api version header file. The definitions in CMakeLists.txt are no longer needed. Signed-off-by: Adrian Warecki <[email protected]>
softwarecki
requested review from
RDharageswari,
abonislawski,
kv2019i,
marcinszkudlinski,
jxstelter,
pjdobrowolski,
tmleman and
serhiy-katsyuba-intel
serhiy-katsyuba-intel
approved these changes
Nov 28, 2023
| } | ||
|
|
||
| frames_processed = 0; | ||
| while (frames_processed < frames_to_process) { |
There was a problem hiding this comment.
I'm struggling with that frames processing. For an outsider it is a bit complex and without knowing how pipelines work looks like magic. @marcinszkudlinski do we have any docs for that?
lgirdwood
requested changes
Nov 29, 2023
| #define ADSP_MAX_VALUE ADSP_FATAL_FAILURE | ||
|
|
||
| /* SystemAgentInterface */ | ||
| #define ADSP_MODULE_CREATION_FAILURE (ADSP_MAX_VALUE + 1) |
There was a problem hiding this comment.
Wont the max value be changed here if we add more errors ?
| @@ -0,0 +1,520 @@ | |||
| // SPDX-License-Identifier: BSD-3-Clause | |||
There was a problem hiding this comment.
Lets not duplicate the module sources in the code base, we should use the same module code regardless of basefw or module/library build.
|
Closing PR as we need to use the same module code for built-in and loadable module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the example of down mixer module ported from iadk. Its build as a native loadable sof module.
Ported additional error code definitions from iadk module API. These codes are not unique and their meaning depends on the context / which function returns it.