Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
sof: coherent: Don't mark "struct coherent" as packed
On 64-bit systems (i.e: i.MX93), marking "struct coherent" as packed leads to compilation warnings such as: "warning: taking address of packed member of 'struct coherent' may result in an unaligned pointer value" This is because the "list" attribute is found at offset 36, which is not 8B-aligned. In contrast, 32-bit systems don't have this problem as the "list" attribute is found at offset 24 which is 4B-aligned. Since marking "struct coherent" as packed doesn't seem to be necessary, remove this to fix the compilation warnings. On 32-bit systems, 'pahole' shows no difference between the 'packed' and the non-'packed' cases as the fields are already naturally aligned at the moment. A more detailed discussion regarding this issue can be found here: #8521. Signed-off-by: Laurentiu Mihalcea <[email protected]>
- Loading branch information