check-kmod-load-unload-after-playback.sh: fix source reference and quote issues. #1042
Conversation
…oting Six issues to zero. Fixed the source reference to match that of other repos. Fixed a single quote issue (a single quote block contained a variable).
| @@ -85,7 +86,7 @@ do | |||
| dlogi "platform doesn't support runtime pm, skip waiting" && break | |||
| [[ $(sof-dump-status.py --dsp_status 0) == "suspended" ]] && break | |||
| sleep 1 | |||
| if [ $i -eq 15 ]; then | |||
| if [ "$i" -eq 15 ]; then | |||
There was a problem hiding this comment.
Can you please add one more commit with this?
| if [ "$i" -eq 15 ]; then | |
| if [ "$i" -ge 15 ]; then |
Much safer in case someone fails to update both duplicates at the same time.
There was a problem hiding this comment.
Why no sign-off in either commit?
There was a problem hiding this comment.
Oversight on my part, sorry.
| case_dir=$(cd "$(dirname "${BASH_SOURCE[0]}")"; pwd) | ||
|
|
||
| OPT_NAME['t']='tplg' OPT_DESC['t']='tplg file, default value is env TPLG: $TPLG' | ||
| OPT_NAME['t']='tplg' OPT_DESC['t']="tplg file, default value is env TPLG: $TPLG" |
Changed -eq 15 to be -ge 15 per Marc. This will catch situations where someone fails to update both duplicates at the same time.
There was a problem hiding this comment.
Changed -eq 15 to be -ge 15 per Marc.
This sounds a bit like "just because X asked" which is definitely not enough of a reason to do a code change!
Now if you want to credit someone else for an incredibly good idea then by all means do it but that's not really how this commit message looks right now.
Also, this particular change is very far from ground-breaking.
Never mind, does not matter. Don't fix it.
Sorry, that wasn't my intent. I was calling it out because you're much more familiar with the test suite and what's being tested to know what situations were covered. I had originally tried to be "too smart" and over-explain, but then I realized that might get me in trouble (and that I was probably wrong on some counts) so I simplified my message. I felt this message lent more credibility to the change. |
|
The rare test failures happened in other tests not modified by this PR. Merging. |
marc-hb
deleted the
check-kmod-load-unload-after-playback-shellcheck-fixes
branch
Fixes per ticket #729
Six issues to zero.
Fixed the source reference to match that of other repos. Fixed a single quote issue (a single quote block contained a variable).
Signed off by Greg Galloway [email protected]