fix all shellcheck warnings

[marc-hb]

shellcheck finds bugs, notably issues with set -e: do this before #312

Related: #740

[greg-intel]

There are currently seven open PRs, once they're all merged I believe this ticket can be closed, @marc-hb ?

[greg-intel]

Think I'm caught up on all the PRs.

[marc-hb]

Could you please update and re-share the spreadsheet to reflect the new status?

[greg-intel]

@marc-hb see any remaining candidates in the ones I left behind?

[greg-intel]

Also of note, Fred proposed a rewrite to run-all-tests: #1019

[marc-hb]

Could you please update and re-share the spreadsheet to reflect the new status?

I meant can you make the fixed tests green and with a "0" to see what's left at a glance? Scanning "19 FIXED" lines one by one does not give any overview (and I'm not even sure what it means)

PS: did you just copy the same image again??

[greg-intel]

I guess the previous image was already up-to-date. Here, I've color coded the status to make it easier to see which files were left out, all files that were fixed or were "0" are green for column C.

[marc-hb]

Thanks, now this gives an overview. "the new status" meant not interested in the number of issues when you started to work on this.

I'm happy to close this and leave the rest for whenever someone wants to resurrect a test.

[marc-hb]

test-case/*.sh not clean yet as of 47af510

test-case/check-audio-equalizer.sh
test-case/check-pause-release-suspend-resume.sh 1 failure
test-case/check-reboot.sh - many failures
test-case/check-runtime-pm-double-active.sh - very many
test-case/check-runtime-pm-status.sh - many
test-case/check-userspace-paplay.sh 1 failure
test-case/check-userspace-parecord.sh 1 failure
test-case/verify-ucm-config.sh many