feat: solved comments | updated tests and parameters

themesberg · Aug 21, 2024 · 7e5e372 · 7e5e372
1 parent 2adc969
commit 7e5e372
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 109 deletions.
diff --git a/packages/ui/src/components/Datepicker/Datepicker.spec.tsx b/packages/ui/src/components/Datepicker/Datepicker.spec.tsx
@@ -57,17 +57,17 @@ describe("Components / Datepicker", () => {
     expect(screen.getByDisplayValue(todaysDateInDefaultLanguage)).toBeInTheDocument();
   });
 
-  it("should call `onSelectedDateChange` when a new date is selected", async () => {
-    const onSelectedDateChange = vi.fn();
+  it("should call `onChange` when a new date is selected", async () => {
+    const onChange = vi.fn();
     const todaysDayOfMonth = new Date().getDate();
     const anotherDay = todaysDayOfMonth === 1 ? 2 : 1;
 
-    render(<Datepicker onSelectedDateChanged={onSelectedDateChange} />);
+    render(<Datepicker onChange={onChange} />);
 
     await userEvent.click(screen.getByRole("textbox"));
     await userEvent.click(screen.getAllByText(anotherDay)[0]);
 
-    expect(onSelectedDateChange).toHaveBeenCalledOnce();
+    expect(onChange).toHaveBeenCalledOnce();
   });
 
   // TODO: fix

diff --git a/packages/ui/src/components/Datepicker/Datepicker.stories.tsx b/packages/ui/src/components/Datepicker/Datepicker.stories.tsx
@@ -40,7 +40,7 @@ const Template: StoryFn<DatepickerProps> = (args) => {
     args.maxDate = new Date(args.maxDate);
   }
 
-  // update defaultValue based on the range
+  // update defaultDate based on the range
   if (args.minDate && args.maxDate) {
     if (args.defaultDate) {
       args.defaultDate = getFirstDateInRange(args.defaultDate, args.minDate, args.maxDate);
@@ -82,7 +82,7 @@ NullDateValue.args = {
   autoHide: true,
   showClearButton: true,
   showTodayButton: true,
-  value: '',
+  value: "",
   minDate: undefined,
   maxDate: undefined,
   language: "en",

diff --git a/packages/ui/src/components/Datepicker/Views/Months.tsx b/packages/ui/src/components/Datepicker/Views/Months.tsx
@@ -2,7 +2,7 @@ import type { FC } from "react";
 import { twMerge } from "tailwind-merge";
 import { mergeDeep } from "../../../helpers/merge-deep";
 import { useDatePickerContext } from "../DatepickerContext";
-import { getFormattedDate, isDateInRange, isMonthEqual, Views } from "../helpers";
+import { getFormattedDate, isDateInRange, Views, isDateEqual } from "../helpers";
 
 export interface FlowbiteDatepickerViewsMonthsTheme {
   items: {

diff --git a/src/components/Datepicker/Datepicker.spec.tsx b/src/components/Datepicker/Datepicker.spec.tsx