Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple from Guzzle by using HTTPlug interfaces. #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Decouple from Guzzle by using HTTPlug interfaces. #29

wants to merge 1 commit into from

Conversation

mekras
Copy link

@mekras mekras commented Oct 26, 2016

HTTPlug allows to write reusable libraries and applications that need an HTTP client without binding to a specific implementation. More about HTTPlug.

@coveralls
Copy link

coveralls commented Oct 26, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 9971fc5 on mekras:php-http into 9c3ffce on theiconic:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9971fc5 on mekras:php-http into 9c3ffce on theiconic:master.

@jorgeborges
Copy link
Contributor

hey @mekras, thanks for the PR. It might take some time for this to merged since this is a big change and so it will most likely be released in Version 3. I also want to make v3 use a lot of PHP 7 new features, I'm currently working on these refactors.

@ddinchev
Copy link

ddinchev commented Mar 3, 2018

@jorgeborges how is v3 progressing? Can we create a milestone for that and write tasks (issues) for the bits that would need refactoring? Maybe the community can help with this.

@@ -11,9 +11,13 @@
],
"require": {
"php": ">=5.5",
"guzzlehttp/guzzle": "^6.0"
Copy link

@qdequippe qdequippe Oct 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about require also psr/http-client-implementation?

@qdequippe
Copy link

@jorgeborges did you plan a v3? I will be happy to contribute :)

@andrekutianski
Copy link

Implementing this PR would be perfect to remove guzzle dependency, I am having to abandon the use of this project due to this.

@alberto-bottarini
Copy link
Contributor

why not psr-18?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants