Fixes #36910 - Expect ERB in URL for test webhook #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The text alignment looks weird. Does it need to be centered? Ftr here's how it looks on failure |
|
Just from looking at the screenshots, the error message is now much more useful, I agree with text alignment not to be center |
ofedoren
force-pushed
the
bug-36910-fix-test-webhook-with-erb
branch
from
38378ad
to
1e0d256
Compare
|
Thanks, @adamruzicka and @pondrejk, fixed the alignment: |
pondrejk
approved these changes
Nov 13, 2023
adamruzicka
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.