Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite GHA workflow using reusable actions #381

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

archanaserver
Copy link
Contributor

@archanaserver archanaserver commented Jan 11, 2024

Updated GitHub Action workflow using shared Rubocop and Foreman plugin test actions.

https://github.com/theforeman/actions#rubocop
https://github.com/theforeman/actions#foreman-plugin-tests

Comment on lines -84 to -91
- name: Run plugin tests
if: github.event_name != 'push'
run: |
bundle exec rake test:foreman_puppet
- name: Run access permission test
if: ${{ github.event_name != 'push' }}
run: |
bundle exec rake test TEST="test/unit/foreman/access_permissions_test.rb"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This steps has not yet executed in the reusable action.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related discussion: theforeman/actions#16

Comment on lines -47 to -48
- name: Install chromedriver
uses: nanasess/setup-chromedriver@master
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekohl i can't see this step execution in the reusable action, do we want to execute this one? i'm not aware of this one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a browser for the acceptance tests. I think a separate container that runs selenium together with theforeman/foreman#9952 could be an alternative. It would be best to track this by opening an issue on https://github.com/theforeman/actions or at least mention it in theforeman/actions#1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@archanaserver
Copy link
Contributor Author

@ekohl how the workflow is not getting triggered? i wonder if any checks i'm missing here :/

Gemfile Outdated Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
@ekohl ekohl merged commit 43b6cef into theforeman:master Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants