Refs #29991 - Fix zeitwerk-related issues

.github/workflows/ruby_tests.yml

@@ -23,3 +23,4 @@ jobs:
     uses: theforeman/actions/.github/workflows/foreman_plugin.yml@v0
     with:
       plugin: foreman_ansible
+      foreman_version: refs/pull/10131/head

app/controllers/ansible_roles_controller.rb

@@ -46,7 +46,7 @@ def default_order
   end
 
   def create_importer
-    @importer = ForemanAnsible::UiRolesImporter.new(@proxy)
+    @importer = ForemanAnsible::UIRolesImporter.new(@proxy)
     @variables_importer = ForemanAnsible::VariablesImporter.new(@proxy)
   end
 

app/controllers/ansible_variables_controller.rb

@@ -92,7 +92,7 @@ def import_new_roles
 
   def create_importer
     @importer = ForemanAnsible::VariablesImporter.new(@proxy)
-    @importer_roles = ForemanAnsible::UiRolesImporter.new(@proxy)
+    @importer_roles = ForemanAnsible::UIRolesImporter.new(@proxy)
   end
 
   def find_required_proxy

app/controllers/api/v2/ansible_playbooks_controller.rb

@@ -39,7 +39,7 @@ def action_permission
       end
 
       def plan_ansible_sync(proxy_id, playbooks_names)
-        ForemanTasks.async_task(ImportPlaybooksJob::Async::SyncPlaybooks, proxy_id, playbooks_names)
+        ForemanTasks.async_task(Actions::SyncPlaybooks, proxy_id, playbooks_names)
       end
 
       private

app/controllers/api/v2/ansible_roles_controller.rb

@@ -98,7 +98,7 @@ def find_proxy
       # rubocop:enable Layout/DotPosition
 
       def create_importer
-        @roles_importer = ForemanAnsible::UiRolesImporter.new(@proxy)
+        @roles_importer = ForemanAnsible::UIRolesImporter.new(@proxy)
         @variables_importer = ForemanAnsible::VariablesImporter.new(@proxy)
         @importer = ForemanAnsible::ApiRolesImporter.new(@proxy)
       end

app/controllers/ui_ansible_roles_controller.rb

@@ -1,4 +1,4 @@
-class UiAnsibleRolesController < ::Api::V2::BaseController
+class UIAnsibleRolesController < ::Api::V2::BaseController
   def resource_name(resource = 'AnsibleRole')
     super resource
   end

app/jobs/sync_roles_and_variables.rb

@@ -2,7 +2,7 @@ class SyncRolesAndVariables < ::ApplicationJob
   queue_as :default
 
   def perform(changed, proxy)
-    roles_importer = ForemanAnsible::UiRolesImporter.new(proxy)
+    roles_importer = ForemanAnsible::UIRolesImporter.new(proxy)
     variables_importer = ForemanAnsible::VariablesImporter.new(proxy)
     roles_importer.finish_import(changed)
     variables_importer.import_variables_roles(changed) if changed['new'] || changed['old']

app/lib/actions/sync_playbooks.rb

@@ -0,0 +1,23 @@
+module Actions
+  class SyncPlaybooks < ::Actions::EntryAction
+    def plan(proxy_id, playbooks_names)
+      plan_self(proxy_id: proxy_id, playbooks_names: playbooks_names)
+    end
+
+    def run
+      playbooks_importer = ForemanAnsible::PlaybooksImporter.new(proxy)
+      output[:result] = playbooks_importer.import_playbooks(playbooks_names)
+      ForemanAnsible::ImportPlaybooksSuccessNotification.deliver!(task)
+    rescue StandardError => e
+      ForemanAnsible::ImportPlaybooksErrorNotification.new(e, task).deliver!
+    end
+
+    def proxy
+      SmartProxy.find(input[:proxy_id])
+    end
+
+    def playbooks_names
+      input[:playbooks_names]
+    end
+  end
+end

app/services/foreman_ansible/api_roles_importer.rb

@@ -6,7 +6,7 @@ class ApiRolesImporter < RolesImporter
     include ::ForemanAnsible::AnsibleRolesDataPreparations
 
     def import!(role_names)
-      @roles_importer = ForemanAnsible::UiRolesImporter.new(@ansible_proxy)
+      @roles_importer = ForemanAnsible::UIRolesImporter.new(@ansible_proxy)
       @variables_importer = ForemanAnsible::VariablesImporter.new(@ansible_proxy)
       params = { 'changed' => {} }
       roles = prepare_ansible_import_rows(@roles_importer.import!, @variables_importer, false)

app/services/foreman_ansible/ui_roles_importer.rb

@@ -2,7 +2,7 @@
 
 module ForemanAnsible
   # imports ansible roles through UI
-  class UiRolesImporter < RolesImporter
+  class UIRolesImporter < RolesImporter
     def import!
       import_role_names
     end

gemfile.d/foreman_remote_execution.local.rb

@@ -0,0 +1 @@
+gem 'foreman_remote_execution', github: 'ofedoren/foreman_remote_execution', branch: 'feat-37453-support-zeitwerk'

gemfile.d/foreman_tasks.local.rb

@@ -0,0 +1 @@
+gem 'foreman-tasks', github: 'ofedoren/foreman-tasks', branch: 'feat-37452-support-zeitwerk'

lib/foreman_ansible/register.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 Foreman::Plugin.register :foreman_ansible do
-  requires_foreman '>= 3.10.0'
+  requires_foreman '>= 3.12.0'
   register_gettext
 
   settings do

test/functional/ansible_variables_controller_test.rb

@@ -25,7 +25,7 @@ class AnsibleVariablesControllerTest < ActionController::TestCase
   test 'there are no problems when the import hash is empty' do
     ForemanAnsible::VariablesImporter.any_instance.
       expects(:import_variable_names).returns({})
-    ForemanAnsible::UiRolesImporter.any_instance.
+    ForemanAnsible::UIRolesImporter.any_instance.
       expects(:import_role_names).returns({})
 
     get :import,

test/functional/ui_ansible_roles_controller_test.rb

@@ -1,6 +1,6 @@
 require 'test_plugin_helper'
 
-class UiAnsibleRolesControllerTest < ActionController::TestCase
+class UIAnsibleRolesControllerTest < ActionController::TestCase
   setup do
     @role = FactoryBot.create(:ansible_role)
   end

test/unit/services/ui_roles_importer_test.rb

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
 require 'test_plugin_helper'
-# unit tests for UiRolesImporter
-class UiRolesImporterTest < ActiveSupport::TestCase
+# unit tests for UIRolesImporter
+class UIRolesImporterTest < ActiveSupport::TestCase
   setup do
     changed_roles
-    @importer = ForemanAnsible::UiRolesImporter.new
+    @importer = ForemanAnsible::UIRolesImporter.new
   end
 
   test 'should create new role' do