Refs #29991 - Fix tests

theforeman · May 2, 2024 · 089d649 · 089d649
1 parent 5c0ff1e
commit 089d649
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 11 deletions.
diff --git a/test/models/token/puppetca_test.rb b/test/models/token/puppetca_test.rb
@@ -1,6 +1,6 @@
 require 'test_helper'
 
-class Token::PuppetcaTest < ActiveSupport::TestCase
+class Token::PuppetCATest < ActiveSupport::TestCase
   should validate_uniqueness_of(:value)
 
   let(:host) { FactoryBot.create(:host) }

diff --git a/test/unit/foreman/http_proxy_test.rb b/test/unit/foreman/http_proxy_test.rb
@@ -1,6 +1,6 @@
 require 'test_helper'
 
-class HttpProxyTest < ActiveSupport::TestCase
+class Foreman::HttpProxyTest < ActiveSupport::TestCase
   class DummyHttpAdapter
     include Foreman::HttpProxy
   end
@@ -106,10 +106,10 @@ class DummyHttpAdapter
   end
 
   describe 'Excon::Connection extension' do
-    let(:excon_connection) { Excon::Connection.new }
+    let(:excon_connection) { ::Excon::Connection.new }
 
     setup do
-      Excon::Connection.class_eval { prepend Foreman::HttpProxy::ExconConnectionExtension } if Excon::Connection.ancestors.first != Foreman::HttpProxy::ExconConnectionExtension
+      ::Excon::Connection.class_eval { prepend Foreman::HttpProxy::ExconConnectionExtension } if ::Excon::Connection.ancestors.first != Foreman::HttpProxy::ExconConnectionExtension
       excon_connection.stubs(:http_proxy).returns(http_proxy)
       excon_connection.stubs(:setup_proxy).returns
       excon_connection.stubs(:proxy_http_request?).returns(true)
@@ -123,7 +123,7 @@ class DummyHttpAdapter
 
     test 'rescues requests and mentions proxy' do
       stub_request(:get, "http://#{request_host}/features").to_raise("AnException")
-      assert_raises_with_message Excon::Error::Socket, "AnException" do
+      assert_raises_with_message ::Excon::Error::Socket, "AnException" do
         excon_connection.request({host: request_host, path: "/features", headers: {}})
       end
     end
@@ -145,7 +145,7 @@ class DummyHttpAdapter
     test 'rescues requests and mentions proxy' do
       stub_request(:get, "http://#{request_host}/features")
       assert_raises_with_message StandardError.new, "Failed to open TCP connection" do
-        net_http.request(Net::HTTP::Get.new("/features"))
+        net_http.request(::Net::HTTP::Get.new("/features"))
       end
     end
   end

diff --git a/test/unit/net/dhcp_test.rb b/test/unit/net/dhcp_test.rb
@@ -1,5 +1,4 @@
 require 'test_helper'
-require 'net'
 
 class DHCPTest < ActiveSupport::TestCase
   setup do

diff --git a/test/unit/net/dns_test.rb b/test/unit/net/dns_test.rb
@@ -1,6 +1,4 @@
 require 'test_helper'
-require 'net'
-require 'net/dns'
 
 class DNSTest < ActiveSupport::TestCase
   setup do

diff --git a/test/unit/net/net_test.rb b/test/unit/net/net_test.rb
@@ -1,5 +1,4 @@
 require 'test_helper'
-require 'net'
 
 class NetTest < ActiveSupport::TestCase
   test "Net record should auto assign attributes" do

diff --git a/test/unit/net/validations_test.rb b/test/unit/net/validations_test.rb
@@ -1,5 +1,4 @@
 require 'test_helper'
-require 'net'
 
 class ValidationsTest < ActiveSupport::TestCase
   describe "validate_mac" do