Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Monitoring_Project to upstream_filename_to_satellite_link.json #3181

Merged

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Aug 2, 2024

I manually verified what was linked on https://docs.redhat.com/en/documentation/red_hat_satellite/6.15

I couldn't find a way to determine this automatically. I looked at docinfo.xml but there's no destination there so I'm assuming it's coded somewhere in a conversion script. foreman_theme_satellite will also use this same info when RedHatSatellite/foreman_theme_satellite#58 is merged so those will need to be kept in sync.

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.11/Katello 4.13
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • We do not accept PRs for Foreman older than 3.5.

Copy link

github-actions bot commented Aug 2, 2024

The PR preview for bffaa0c is available at theforeman-foreman-documentation-preview-pr-3181.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@ekohl ekohl mentioned this pull request Aug 6, 2024
9 tasks
@ekohl ekohl force-pushed the fix-upstream-to-satellite-link-mapping branch from 4ed4e1e to bffaa0c Compare August 8, 2024 11:12
@ekohl ekohl changed the title Update upstream_filename_to_satellite_link mapping Add Monitoring_Project to upstream_filename_to_satellite_link.json Aug 8, 2024
@ekohl
Copy link
Member Author

ekohl commented Aug 8, 2024

Rebased after #3185 was merged. Now it only adds the monitoring guide.

@ekohl ekohl requested a review from Lennonka August 8, 2024 11:13
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we forgot about this earlier. It's correct. Thank you!

@ekohl ekohl merged commit 0b62c17 into theforeman:master Aug 8, 2024
7 of 8 checks passed
@ekohl ekohl deleted the fix-upstream-to-satellite-link-mapping branch August 8, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants