Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to postgresql-evr #3167

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Remove references to postgresql-evr #3167

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a439ca
Remove references to postgresql-evr
ianballou Jul 25, 2024
80d52a6
Remove references to Foreman repositories for external DBs
ianballou Jul 31, 2024
1149379
Add release note for new remote DB possibilities
ianballou Aug 5, 2024
fd58d72
Remove excess parts of external DB host setup
ianballou Aug 5, 2024
987cc45
Remove prepping a host for ext DBs guide + introduce evr permissions …
ianballou Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions guides/common/modules/proc_installing-postgresql.adoc
View file
Open in desktop
ekohl marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
= Installing PostgreSQL

You can install only the same version of PostgreSQL that is installed with the `{foreman-installer}` tool during an internal database installation.
{Project} supports PostgreSQL version 12.
{Project} supports PostgreSQL version 13.

include::snip_firewalld.adoc[]

Expand All @@ -12,7 +12,7 @@ include::snip_firewalld.adoc[]
+
----
ifdef::katello,satellite,orcharhino[]
# dnf install postgresql-server postgresql-evr postgresql-contrib
# dnf install postgresql-server postgresql-contrib
endif::[]
ifndef::katello,satellite,orcharhino[]
# dnf install postgresql-server
Expand Down
30 changes: 2 additions & 28 deletions guides/common/modules/proc_preparing-a-host-for-external-databases.adoc
View file
Open in desktop
ekohl marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think you can drop lines 6-9 because now a base RHEL subscription gives you access to the right repositories. Though with service level agreement I'm a bit uncertain.

Do we still need procedure? After removing the specific Satellite repositories, isn't it sufficient to say you need a RHEL 8 or 9 system with an attached subscription? Essentially, drop the whole chapter Preparing a host for external databases and make them prerequisites in the Installing PostgreSQL procedure

@asteflova @apinnick what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've ripped out so much of this page that I think I could just include this info as prerequisites.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me from the docs perspective. Looking at the procedure steps, it looks like you could save a lot of space by shrinking it into a prerequisite bullet without losing much value. More importantly (to me), anything that's a prerequisite should be labeled as "prerequisite", not "preparing" or anything like that. We are supposed to apply the same wording and terminology consistently (this helps make the content predictable).

Original file line number Diff line number Diff line change
Expand Up @@ -39,21 +39,14 @@ ifdef::satellite[]
[options="nowrap" subs="+quotes,attributes"]
----
# subscription-manager repos \
--enable={RepoRHEL9ServerSatelliteServerProjectVersion} \
--enable={RepoRHEL9ServerSatelliteMaintenanceProjectVersion} \
--enable={RepoRHEL9BaseOS} \
--enable={RepoRHEL9AppStream}
----
endif::[]

ifdef::katello[]
. Install the `katello-repos-latest.rpm` package
. Ensure that the {EL} 9 BaseOS and Appstream repositories are enabled.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For upstream, this is now the same as EL 8 so at the very least we can drop them. I'd actually consider dropping the whole repository setup for upstream. Essentially you want a basic OS install which I'd feel confident in assuming from users.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with that.

+
[options="nowrap" subs="+quotes,attributes"]
----
# {client-package-install-el8} https://yum.theforeman.org/releases/{ProjectVersion}/el{distribution-major-version}/x86_64/foreman-release.rpm \
https://yum.theforeman.org/katello/{KatelloVersion}/katello/el{distribution-major-version}/x86_64/katello-repos-latest.rpm
----
endif::[]

include::snip_verification-enabled-repolist.adoc[]
Expand All @@ -75,35 +68,16 @@ ifdef::satellite[]
[options="nowrap" subs="+quotes,attributes"]
----
# subscription-manager repos \
--enable={RepoRHEL8ServerSatelliteServerProjectVersion} \
--enable={RepoRHEL8ServerSatelliteMaintenanceProjectVersion} \
--enable={RepoRHEL8BaseOS} \
--enable={RepoRHEL8AppStream}
----
endif::[]

ifdef::katello[]
. Install the `katello-repos-latest.rpm` package
. Ensure that the {EL} 8 BaseOS and Appstream repositories are enabled.
+
[options="nowrap" subs="+quotes,attributes"]
----
# {client-package-install-el8} https://yum.theforeman.org/releases/{ProjectVersion}/el{distribution-major-version}/x86_64/foreman-release.rpm \
https://yum.theforeman.org/katello/{KatelloVersion}/katello/el{distribution-major-version}/x86_64/katello-repos-latest.rpm
----
endif::[]

. Enable the following module:
+
[options="nowrap" subs="+quotes,attributes"]
----
# dnf module enable {dnf-module}
----
+
[NOTE]
====
include::snip_dnf-module-enable-note.adoc[]
====

include::snip_verification-enabled-repolist.adoc[]
endif::[]
ifdef::orcharhino[]
Expand Down
3 changes: 2 additions & 1 deletion guides/doc-Release_Notes/topics/katello.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
[id="katello-headline-features"]
== Headline Features

There are no highlights with Katello {KatelloVersion}.
Remote installation of the Katello database on systems where root access is not available is now possible.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We always add headers, so something like

Suggested change
Remote installation of the Katello database on systems where root access is not available is now possible.
=== postgresql-evr extension no longer required
Installation of the Katello database on remote systems where root access is not available is now possible.

And perhaps also note that you only need a basic PostgreSQL installation now, which means it probably also works with managed databases like Amazon RDS and others.

The contents of postgresql-evr have been moved into Katello itself as a migration, which enables this new capability.

[id="katello-upgrade-warnings"]
== Upgrade Warnings
Expand Down