Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImageButton component #10

Merged
merged 21 commits into from
Sep 12, 2024
Merged

Conversation

AyIong
Copy link
Contributor

@AyIong AyIong commented Aug 5, 2024

Original PR - tgstation/tgstation#85578

About

A new component to standardise all image buttons.
It has the ability to assign an action to the right mouse button - onRightClick={() => {}}

Unsure about building, so tell me revert if needed

Demonstration

Pictures
Smartfridge Smartridge (Fluid) Loadout
image image image

@AyIong AyIong changed the title Add Image button component Add ImageButton component Aug 5, 2024
@optimumtact
Copy link
Member

we are so back

Copy link
Member

@jlsnow301 jlsnow301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks pretty good, but there seems to be a build artifact

dist/common/string.d.ts Outdated Show resolved Hide resolved
@ZephyrTFA
Copy link
Contributor

@jlsnow301 we should add a workflow to automatically build and push to branch

@ZeWaka
Copy link
Collaborator

ZeWaka commented Aug 7, 2024

@jlsnow301 we should add a workflow to automatically build and push to branch

That's what my release workflow PR does.
It's more so that we just need to decide what the workflow is going to be so we can code automation around it.

package.json Outdated Show resolved Hide resolved
lib/components/ImageButton.tsx Outdated Show resolved Hide resolved
lib/components/ImageButton.tsx Outdated Show resolved Hide resolved
lib/components/ImageButton.tsx Show resolved Hide resolved
@ZeWaka ZeWaka merged commit 625bada into tgstation:main Sep 12, 2024
1 check passed
@AyIong AyIong deleted the ImageButton-component branch September 12, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants