Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(t8s-cluster): prepare for flux drift-detection #322

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

cwrau
Copy link
Member

@cwrau cwrau commented Mar 27, 2023

No description provided.

@cwrau cwrau requested a review from marvinWolff as a code owner March 27, 2023 14:52
@cwrau cwrau enabled auto-merge (squash) March 27, 2023 14:52
@teutonet-bot
Copy link
Contributor

🤖 I have diffed this beep boop

"/$namespace/$kind/$name.yaml" for normal resources
"/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive
'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

charts/t8s-cluster/ci/artifacthub-values.yaml

charts/t8s-cluster/ci/lint-calico-values.yaml

charts/t8s-cluster/ci/securityGroups-values.yaml has no changes

charts/t8s-cluster/ci/lint-values.yaml

charts/t8s-cluster/ci/bastion-values.yaml

charts/t8s-cluster/values.yaml has no changes

@ghost
Copy link

ghost commented Apr 11, 2023

Code-Changes look good to me. However I don't get the correlation to flux drift-detection. Maybe a more verbose description would help?

@cwrau
Copy link
Member Author

cwrau commented Apr 11, 2023

Code-Changes look good to me. However I don't get the correlation to flux drift-detection. Maybe a more verbose description would help?

Ah, sorry, must've got lost, I meant to refer to the new flux feature

@ghost
Copy link

ghost commented Apr 14, 2023

I do get, what drift detection is. I also do approve choosing a bigger interval for helm-releases. Especially since 1m is pretty fast.

What I don't get is, what's the connection between longer intervals and drift detection. To me, these are two independent things.

@cwrau
Copy link
Member Author

cwrau commented Apr 14, 2023

I do get, what drift detection is. I also do approve choosing a bigger interval for helm-releases. Especially since 1m is pretty fast.

What I don't get is, what's the connection between longer intervals and drift detection. To me, these are two independent things.

Currently the interval doesn't do anything, therefore even 1s wouldn't be a problem. But in the, hopefully near, future flux will really reconcile the HelmReleases at the specified interval.

This of course causes semi-high load. And as we don't really expect there to be many random deletion / changes of the created resources it's good to have a semi-long interval as not to overload flux.

@marvinWolff
Copy link
Collaborator

You mean because the drift detection would do the dry-run on every reconcile?

Changes look good to me 👍

@ghost
Copy link

ghost commented Apr 14, 2023

Ah, see. That's what I mean by a more verbose description. This really helps understanding the relevance of these changes.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants