[pull] master from MarketSquare:master #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
From my somewhat limited looking into all the Python database modules only pymssql allows for the as_dict argument. This change makes it not an inclusion of all the other modules but an exclusion except for the one, pymssql.
- Switched dbConfigFile from hardcoded default argument to None and then a check if None set to value. This might not be necessary as a string should NOT be a mutable object and thus not a problem. But going to leave this in here anyways. I'll note I don't know what this configfile is nor is there a resource folder so this might need to be updated anyways. - Corrected issue with the PyODBC connection string with the correct format being host:port and not a comma between the two.
Initial GitHub actions tests
…support information schema
…script for local execution
… was no connection
… it can stay as object with the value 'disconnected' (e.g. in Oracle) - in this case a next call of the keyword 'Disconnect From Database' won't work properly
This reverts commit 17a0704.
…on strings with and without quotes
…on String" for connection strings. The original keyword 'Connect using custom params' handles params map strings only,
Fix handling query params for MS SQL #211
… 5.0.1 (#215) * Keyword 'Check Row Count' using assertion engine * Deprecate old "row count" assertion keywords * Link to Assertion Engine in docs * Deprecate duplicating "check exists" assertion keywords * Log returned number of rows for possible debugging purposes * Put Assertion Engine to dependencies * Require min. Python 3.8 and RF 5.0.1 * improve common docs * New keyword 'Check Query Result' * Typo in docs
* Log query results as a table (fix #147) * Formatting * Consistent naming of internal functions
… a dedicated keyword 'Set Logging Query Results' (#218)
…in a separate list
Calling a stored procedure in MSSQL - special handling of OUT params
The entire connection logic and implementation was refactored
* There is only one mandatory parameter left - dbapiModuleName, it must be set - either as keyword argument or in config file.
* All other parameters are optional now. So if some connection data was missing, the error would come not from the Database Library, but from the Python DB module.
* If some params are not provided, they are not set to None - they are just not passed to the Python DB module at all.
* Other custom params from keyword arguments and config file are passed to the Python DB module as provided
* All parameters can be now set in a config file - including any custom params
* If same custom parameter is provided both as a keyword argument and in config file, the keyword argument value takes precedence.
Other changes
* Deprecate the Connect To Database Using Custom Params Keyword - it's not needed anymore, the updated Connect To Database keyword replaces it fully
* Stop using localhost as fallback value for DB host
* Stop using {SQL Server} as fallback value for pyodbc driver
* Update docs for the Connect To Database keyword, move docs for using the config file in a separate section
* Pythonic naming for keyword arguments (fix Use Python convention naming #188) * Shorter / more precise names for some parameters * Big cleanup of all docs
… set empty, allow custom params in connection string (similar to pyodbc), "TCPIP" is no default protocol value anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )