Fixes issues where remove_images fails if the image is in use #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damacus
previously approved these changes
Aug 21, 2023
|
Will batch release this, this week. |
damacus
approved these changes
Nov 14, 2023
|
Closing in favour of #406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, when
remove_imageswas set to true, you would receive an error if the image was in use somewhere else. This fixes it by checking to see if the image is in use and skipping image removal if that is the case. It takes the idea presented in #361 and incorporates the feedback on that PR.Issues Resolved
This PR fixes #360
Check List