Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow managing allocated_storage for replicas #534

Conversation

relu
Copy link
Contributor

@relu relu commented Jan 15, 2024

Description

A regression was introduced via c66cd73 where allocated_storage can only be set on primary instances. However, this should not be a limitation because RDS does allow managing replica storage independently from the primary.

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Feb 15, 2024
A regression was introduced via c66cd73 where allocated_storage can only be
set on primary instances. However, this should not be a limitation because RDS
does allow managing replica storage independently from the primary.
@relu relu force-pushed the fix-allow-manage-replica-storage-allocation branch from e1b3d44 to 496da22 Compare February 15, 2024 09:42
@github-actions github-actions bot removed the stale label Feb 16, 2024
@bryantbiggs bryantbiggs changed the title fix: Allow managing allocated_storage for replicas fix: Allow managing allocated_storage for replicas Mar 4, 2024
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit 7b02569 into terraform-aws-modules:master Mar 4, 2024
23 checks passed
antonbabenko pushed a commit that referenced this pull request Mar 4, 2024
### [6.5.1](v6.5.0...v6.5.1) (2024-03-04)

### Bug Fixes

* Allow managing `allocated_storage` for replicas ([#534](#534)) ([7b02569](7b02569))
@antonbabenko
Copy link
Member

This PR is included in version 6.5.1 🎉

@relu relu deleted the fix-allow-manage-replica-storage-allocation branch March 7, 2024 06:50
Copy link

github-actions bot commented Apr 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants