Run top-level functional test suites in parallel

tests/acquire_shard_test.go

@@ -32,12 +32,14 @@ import (
 
 // TestAcquireShard_OwnershipLostErrorSuite tests what happens when acquire shard returns an ownership lost error.
 func TestAcquireShard_OwnershipLostErrorSuite(t *testing.T) {
+	t.Parallel()
 	s := new(OwnershipLostErrorSuite)
 	suite.Run(t, s)
 }
 
 // TestAcquireShard_DeadlineExceededErrorSuite tests what happens when acquire shard returns a deadline exceeded error
 func TestAcquireShard_DeadlineExceededErrorSuite(t *testing.T) {
+	t.Parallel()
 	s := new(DeadlineExceededErrorSuite)
 	suite.Run(t, s)
 }
@@ -46,6 +48,7 @@ func TestAcquireShard_DeadlineExceededErrorSuite(t *testing.T) {
 // exceeded error followed by a successful acquire shard call.
 // To make this test deterministic, we set the seed to in the config file to a fixed value.
 func TestAcquireShard_EventualSuccess(t *testing.T) {
+	t.Parallel()
 	s := new(EventualSuccessSuite)
 	suite.Run(t, s)
 }

tests/activity.go

@@ -1394,7 +1394,7 @@ func (s *ActivityTestSuite) TestActivityHeartBeat_RecordIdentity() {
 
 func (s *ActivityTestSuite) TestActivityTaskCompleteForceCompletion() {
 	sdkClient, err := sdkclient.Dial(sdkclient.Options{
-		HostPort:  s.GetTestCluster().Host().FrontendGRPCAddress(),
+		HostPort:  s.FrontendGRPCAddress(),
 		Namespace: s.Namespace(),
 	})
 	s.NoError(err)
@@ -1431,7 +1431,7 @@ func (s *ActivityTestSuite) TestActivityTaskCompleteForceCompletion() {
 
 func (s *ActivityTestSuite) TestActivityTaskCompleteRejectCompletion() {
 	sdkClient, err := sdkclient.Dial(sdkclient.Options{
-		HostPort:  s.GetTestCluster().Host().FrontendGRPCAddress(),
+		HostPort:  s.FrontendGRPCAddress(),
 		Namespace: s.Namespace(),
 	})
 	s.NoError(err)

tests/activity_test.go

@@ -30,10 +30,12 @@ import (
 )
 
 func TestActivityTestSuite(t *testing.T) {
+	t.Parallel()
 	flag.Parse()
 	suite.Run(t, &ActivityTestSuite{})
 }
 
 func TestActivityClientTestSuite(t *testing.T) {
+	t.Parallel()
 	suite.Run(t, new(ActivityClientTestSuite))
 }

tests/add_tasks.go

@@ -271,7 +271,7 @@ func (s *AddTasksSuite) TestAddTasks_GetEngineErr() {
 
 func (s *AddTasksSuite) newSDKClient() sdkclient.Client {
 	client, err := sdkclient.Dial(sdkclient.Options{
-		HostPort:  s.HostPort(),
+		HostPort:  s.FrontendGRPCAddress(),
 		Namespace: s.Namespace(),
 	})
 	s.NoError(err)

tests/add_tasks_test.go

@@ -31,5 +31,6 @@ import (
 )
 
 func TestAddTasksSuite(t *testing.T) {
+	t.Parallel()
 	suite.Run(t, new(AddTasksSuite))
 }

tests/admin_test.go

@@ -31,5 +31,6 @@ import (
 )
 
 func TestAdminTestSuite(t *testing.T) {
+	t.Parallel()
 	suite.Run(t, new(AdminTestSuite))
 }

tests/archival_test.go

@@ -34,6 +34,7 @@ import (
 )
 
 func TestArchivalSuite(t *testing.T) {
+	t.Parallel()
 	flag.Parse()
 	s := new(ArchivalSuite)
 	dynamicConfigOverrides := map[dynamicconfig.Key]any{

tests/callbacks_test.go

@@ -66,6 +66,7 @@ type CallbacksSuite struct {
 }
 
 func TestCallbacksSuite(t *testing.T) {
+	t.Parallel()
 	suite.Run(t, new(CallbacksSuite))
 }
 
@@ -245,7 +246,7 @@ func (s *CallbacksSuite) TestWorkflowNexusCallbacks_CarriedOver() {
 		s.T().Run(tc.name, func(t *testing.T) {
 			ctx := testcore.NewContext()
 			sdkClient, err := client.Dial(client.Options{
-				HostPort:  s.GetTestCluster().Host().FrontendGRPCAddress(),
+				HostPort:  s.FrontendGRPCAddress(),
 				Namespace: s.Namespace(),
 			})
 			s.NoError(err)

tests/cancel_workflow_test.go

@@ -31,5 +31,6 @@ import (
 )
 
 func TestCancelWorkflowSuite(t *testing.T) {
+	t.Parallel()
 	suite.Run(t, new(CancelWorkflowSuite))
 }

tests/child_workflow_test.go

@@ -31,5 +31,6 @@ import (
 )
 
 func TestChildWorkflowSuite(t *testing.T) {
+	t.Parallel()
 	suite.Run(t, new(ChildWorkflowSuite))
 }

tests/client_data_converter.go

@@ -101,7 +101,7 @@ func testChildWorkflow(ctx workflow.Context, totalCount, runCount int) (string,
 
 func (s *ClientDataConverterTestSuite) startWorkerWithDataConverter(tl string, dataConverter converter.DataConverter) (sdkclient.Client, worker.Worker) {
 	sdkClient, err := sdkclient.Dial(sdkclient.Options{
-		HostPort:      s.HostPort(),
+		HostPort:      s.FrontendGRPCAddress(),
 		Namespace:     s.Namespace(),
 		DataConverter: dataConverter,
 	})

tests/client_data_converter_test.go

@@ -31,5 +31,6 @@ import (
 )
 
 func TestClientDataConverterTestSuite(t *testing.T) {
+	t.Parallel()
 	suite.Run(t, new(ClientDataConverterTestSuite))
 }

tests/client_misc_test.go

@@ -32,6 +32,7 @@ import (
 )
 
 func TestClientMiscTestSuite(t *testing.T) {
+	t.Parallel()
 	flag.Parse()
 	suite.Run(t, new(ClientMiscTestSuite))
 }

tests/continue_as_new_test.go

@@ -32,6 +32,7 @@ import (
 )
 
 func TestContinueAsNewTestSuite(t *testing.T) {
+	t.Parallel()
 	flag.Parse()
 	suite.Run(t, new(ContinueAsNewTestSuite))
 }

tests/cron_test.go

@@ -32,6 +32,7 @@ import (
 )
 
 func TestCronTestSuite(t *testing.T) {
+	t.Parallel()
 	flag.Parse()
 	suite.Run(t, new(CronTestSuite))
 }

tests/describe_task_queue_test.go

@@ -30,6 +30,7 @@ import (
 )
 
 func TestDescribeTaskQueueSuite(t *testing.T) {
+	t.Parallel()
 	flag.Parse()
 	suite.Run(t, new(DescribeTaskQueueSuite))
 }

tests/describe_test.go

@@ -32,6 +32,7 @@ import (
 )
 
 func TestDescribeTestSuite(t *testing.T) {
+	t.Parallel()
 	flag.Parse()
 	suite.Run(t, new(DescribeTestSuite))
 }

tests/dlq.go

@@ -156,12 +156,12 @@ func (s *DLQSuite) SetupSuite() {
 	)
 	s.tdbgApp = tdbgtest.NewCliApp(
 		func(params *tdbg.Params) {
-			params.ClientFactory = tdbg.NewClientFactory(tdbg.WithFrontendAddress(s.HostPort()))
+			params.ClientFactory = tdbg.NewClientFactory(tdbg.WithFrontendAddress(s.FrontendGRPCAddress()))
 			params.Writer = &s.writer
 		},
 	)
 	sdkClient, err := sdkclient.Dial(sdkclient.Options{
-		HostPort:  s.HostPort(),
+		HostPort:  s.FrontendGRPCAddress(),
 		Namespace: s.Namespace(),
 	})
 	s.NoError(err)
@@ -506,7 +506,7 @@ func (s *DLQSuite) verifyRunIsInDLQ(
 // executeWorkflow just executes a simple no-op workflow that returns "hello" and returns the sdk workflow run.
 func (s *DLQSuite) executeWorkflow(ctx context.Context, workflowID string) sdkclient.WorkflowRun {
 	sdkClient, err := sdkclient.Dial(sdkclient.Options{
-		HostPort:  s.HostPort(),
+		HostPort:  s.FrontendGRPCAddress(),
 		Namespace: s.Namespace(),
 	})
 	s.NoError(err)

tests/dlq_test.go

@@ -32,6 +32,7 @@ import (
 )
 
 func TestDLQSuite(t *testing.T) {
+	t.Parallel()
 	flag.Parse()
 	suite.Run(t, new(DLQSuite))
 }

tests/eager_workflow_start.go

@@ -114,11 +114,7 @@ func (s *EagerWorkflowTestSuite) pollWorkflowTaskQueue() *workflowservice.PollWo
 }
 
 func (s *EagerWorkflowTestSuite) getWorkflowStringResult(workflowID, runID string) string {
-	hostPort := "127.0.0.1:7134"
-	if testcore.TestFlags.FrontendAddr != "" {
-		hostPort = testcore.TestFlags.FrontendAddr
-	}
-	c, err := client.Dial(client.Options{HostPort: hostPort, Namespace: s.Namespace()})
+	c, err := client.Dial(client.Options{HostPort: s.FrontendGRPCAddress(), Namespace: s.Namespace()})
 	s.Require().NoError(err)
 	run := c.GetWorkflow(testcore.NewContext(), workflowID, runID)
 	var result string

tests/eager_workflow_start_test.go

@@ -31,5 +31,6 @@ import (
 )
 
 func TestEagerWorkflowTestSuite(t *testing.T) {
+	t.Parallel()
 	suite.Run(t, new(EagerWorkflowTestSuite))
 }

tests/gethistory_test.go

@@ -32,16 +32,19 @@ import (
 )
 
 func TestRawHistorySuite(t *testing.T) {
+	t.Parallel()
 	flag.Parse()
 	suite.Run(t, new(RawHistorySuite))
 }
 
 func TestRawHistoryClientSuite(t *testing.T) {
+	t.Parallel()
 	flag.Parse()
 	suite.Run(t, new(RawHistoryClientSuite))
 }
 
 func TestGetHistoryFunctionalSuite(t *testing.T) {
+	t.Parallel()
 	flag.Parse()
 	suite.Run(t, new(GetHistoryFunctionalSuite))
 }

tests/http_api_test.go

@@ -71,6 +71,7 @@ type HttpApiTestSuite struct {
 }
 
 func TestHttpApiTestSuite(t *testing.T) {
+	t.Parallel()
 	suite.Run(t, new(HttpApiTestSuite))
 }
 

tests/max_buffered_event_test.go

@@ -31,5 +31,6 @@ import (
 )
 
 func TestMaxBufferedEventSuite(t *testing.T) {
+	t.Parallel()
 	suite.Run(t, new(MaxBufferedEventSuite))
 }

tests/namespace/namespace_interceptor_test.go

@@ -31,5 +31,6 @@ import (
 )
 
 func TestNamespaceInterceptorTestSuite(t *testing.T) {
+	t.Parallel()
 	suite.Run(t, new(NamespaceInterceptorTestSuite))
 }

tests/ndc/ndc_test.go

@@ -101,6 +101,7 @@ type (
 )
 
 func TestNDCFuncTestSuite(t *testing.T) {
+	// TODO: doesn't work yet: t.Parallel()
 	flag.Parse()
 	suite.Run(t, new(NDCFunctionalTestSuite))
 }

tests/ndc/replication_migration_back_test.go

@@ -89,6 +89,7 @@ type (
 )
 
 func TestReplicationMigrationBackTest(t *testing.T) {
+	// TODO: doesn't work yet: t.Parallel()
 	flag.Parse()
 	suite.Run(t, new(ReplicationMigrationBackTestSuite))
 

tests/ndc/replication_task_batching_test.go

@@ -87,6 +87,7 @@ type (
 )
 
 func TestNDCReplicationTaskBatching(t *testing.T) {
+	// TODO: doesn't work yet: t.Parallel()
 	flag.Parse()
 	suite.Run(t, new(NDCReplicationTaskBatchingTestSuite))
 }

tests/nexus/nexus_api_test.go

@@ -60,6 +60,7 @@ type NexusApiTestSuite struct {
 }
 
 func TestNexusApiTestSuite(t *testing.T) {
+	t.Parallel()
 	suite.Run(t, new(NexusApiTestSuite))
 
 }

tests/nexus/nexus_endpoint_test.go

@@ -45,6 +45,7 @@ import (
 )
 
 func TestNexusEndpointsFunctionalSuite(t *testing.T) {
+	t.Parallel()
 	t.Run("Common", func(t *testing.T) {
 		s := new(CommonSuite)
 		suite.Run(t, s)

tests/nexus/nexus_workflow_test.go

@@ -65,6 +65,7 @@ type NexusWorkflowTestSuite struct {
 }
 
 func TestNexusWorkflowTestSuite(t *testing.T) {
+	t.Parallel()
 	suite.Run(t, new(NexusWorkflowTestSuite))
 }
 

tests/purge_dlq_tasks_api_test.go

@@ -31,5 +31,6 @@ import (
 )
 
 func TestPurgeDLQTasksSuite(t *testing.T) {
+	t.Parallel()
 	suite.Run(t, new(PurgeDLQTasksSuite))
 }

tests/query_workflow_test.go

@@ -31,5 +31,6 @@ import (
 )
 
 func TestQueryWorkflowSuite(t *testing.T) {
+	t.Parallel()
 	suite.Run(t, new(QueryWorkflowSuite))
 }

tests/relay_task_test.go

@@ -31,5 +31,6 @@ import (
 )
 
 func TestRelayTaskTestSuite(t *testing.T) {
+	t.Parallel()
 	suite.Run(t, new(RelayTaskTestSuite))
 }

tests/schedule.go

@@ -104,7 +104,7 @@ func (s *ScheduleFunctionalSuite) SetupTest() {
 	s.HistoryRequire = historyrequire.New(s.T())
 	s.dataConverter = testcore.NewTestDataConverter()
 	sdkClient, err := sdkclient.Dial(sdkclient.Options{
-		HostPort:      s.HostPort(),
+		HostPort:      s.FrontendGRPCAddress(),
 		Namespace:     s.Namespace(),
 		DataConverter: s.dataConverter,
 	})

tests/schedule_test.go

@@ -32,6 +32,7 @@ import (
 )
 
 func TestScheduleFunctionalSuite(t *testing.T) {
+	t.Parallel()
 	flag.Parse()
 	suite.Run(t, new(ScheduleFunctionalSuite))
 }

tests/signal_workflow_test.go

@@ -31,5 +31,6 @@ import (
 )
 
 func TestSignalWorkflowTestSuite(t *testing.T) {
+	t.Parallel()
 	suite.Run(t, new(SignalWorkflowTestSuite))
 }

tests/sizelimit_test.go

@@ -32,6 +32,7 @@ import (
 )
 
 func TestSizeLimitFunctionalSuite(t *testing.T) {
+	t.Parallel()
 	flag.Parse()
 	suite.Run(t, new(SizeLimitFunctionalSuite))
 }

tests/stickytq_test.go

@@ -31,5 +31,6 @@ import (
 )
 
 func TestStickyTqTestSuite(t *testing.T) {
+	t.Parallel()
 	suite.Run(t, new(StickyTqTestSuite))
 }

tests/testcore/client_suite.go

@@ -111,7 +111,7 @@ func (s *ClientFunctionalSuite) SetupTest() {
 		"http://"+s.HttpAPIAddress()+"/namespaces/{{.NamespaceName}}/nexus/callback")
 
 	sdkClient, err := sdkclient.Dial(sdkclient.Options{
-		HostPort:  s.HostPort(),
+		HostPort:  s.FrontendGRPCAddress(),
 		Namespace: s.Namespace(),
 	})
 	if err != nil {

tests/testcore/flag.go

@@ -34,7 +34,6 @@ import (
 
 // TestFlags contains the feature flags for functional tests
 var TestFlags struct {
-	FrontendAddr             string
 	FrontendHTTPAddr         string
 	PersistenceType          string
 	PersistenceDriver        string
@@ -43,7 +42,6 @@ var TestFlags struct {
 }
 
 func init() {
-	flag.StringVar(&TestFlags.FrontendAddr, "frontendAddress", "", "host:port for temporal frontend service")
 	flag.StringVar(&TestFlags.FrontendHTTPAddr, "frontendHttpAddress", "", "host:port for temporal frontend HTTP service (only applies when frontendAddress set)")
 	flag.StringVar(&TestFlags.PersistenceType, "persistenceType", "sql", "type of persistence - [nosql or sql]")
 	flag.StringVar(&TestFlags.PersistenceDriver, "persistenceDriver", "sqlite", "driver of nosql/sql - [cassandra, mysql8, postgres12, sqlite]")