Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run top-level functional test suites in parallel #6595

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Run top-level functional test suites in parallel #6595

wants to merge 10 commits into from
+151 −89

Conversation

dnr
Copy link
Member

@dnr dnr commented Oct 3, 2024 •
edited
Loading

What changed?

  • Automatically assign cluster number so test clusters don't conflict on ips/ports.
  • Remove ability to run functional tests against external (non-managed) cluster. This probably hasn't worked for a while.
  • Set t.Parallel() on most functional tests (ndc doesn't work yet, but those are fast anyway).

Why?

faster functional tests, better resource usage

How did you test it?

is tests

Potential risks

  • We may need to limit parallelism further to avoid using too much memory, Go's default is GOMAXPROCS, i.e. number of cores.
  • Logs are much harder to read.

@dnr dnr requested a review from a team as a code owner October 3, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dnr