Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move funcional tests back into _test files #6593

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ychebotarev
Copy link
Contributor

@ychebotarev ychebotarev commented Oct 3, 2024

What changed?

"merge" test files. Instead of all test functions in xxxx.go and actual test execution xxx_test.go everything is in xxxx_test.go

Why?

This remove a lot of pain for internal developement, and will allow us to make an improvements to our functional testing process.

How did you test it?

by running tests

Is hotfix candidate?

No

@ychebotarev ychebotarev requested a review from a team as a code owner October 3, 2024 00:16
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look in too much depth. Assuming the tests stayed as-is. I would like to understand the impact on test duration with this setup.

Copy link
Member

@dnr dnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do this with one PR that is pure code movement and nothing else (that we don't have to look at carefully), and all other changes including lint in another PR (that we have to actually review)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants