-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to send to CB batch update for multimeasures for NGSI-LD #1623
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think it would be better to delete them, for cleanness, please. |
An entry in CHANGES_NEXT_RELEASE describing the change in this PR (including issue reference, if any) would be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Equivalent of #1607 - it is just a copy of
sendUpdateValueNgsi2()
for now with relevant changes for NGSI-LD.At some point the v2 functionality had been updated to :
Not update value in the Context Broker with an empty payload
.This path is more frequent in NGSI-LD as attributes which resolve to
null
are already removed. This leads to the update of a large number of test expectations where an "empty entity" was being appended to the upsert.Several (mainly JEXL) tests are no longer relevant, since they result in a
null
and no CB update - I have currently set those tests to PENDING for now pending further review - I can delete them if necessary.