-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Service Header to use upper case value #1613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note the merge conflict. It should be easy to solve, just adding the existing and new lines. |
The PR looks good, thank you so much for your contribution. Being said that, I have a couple of comments:
|
Hi @mapedraza ,
I have added test case for deletion and updation with FIWARE-service in uppercase.
As mentioned in issue, the bug exists for deletion and updation only. Group create and read is working fine. |
Hi @fgalan , If the PR seems OK, please merge the PR. |
Fixes #1528. Now, uppercase value can also be used for service header in case of update and delete.