Remove skip from the ResultInterpret enumeration
#3269
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed today, the `skip` value was never documented in the test `result` key specification and was added by an accident. There seems to be a use case to support skipping selected tests but that functionality is substantially different from the result interpretation configured by the `result` key which happens only after test execution is completed so most probably a new test key should be introduced for it.
psss
requested review from
lukaszachy,
happz,
thrix and
janhavlin
as code owners
psss
added
code | schema
happz
approved these changes
Oct 8, 2024
martinhoyer
approved these changes
Oct 8, 2024
|
/packit test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed today, the
skipvalue was never documented in the testresultkey specification and was added by an accident.There seems to be a use case to support skipping selected tests but that functionality is substantially different from the result interpretation configured by the
resultkey which happens only after test execution is completed so most probably a new test key should be introduced for it.Pull Request Checklist