Add install prepare plugin using install into tmt try (#3071)

Co-authored-by: Ismail Ibrahim Quwarah <[email protected]> Co-authored-by: Petr Šplíchal <[email protected]> Co-authored-by: Miloš Prchlík <[email protected]>
teemtee · Oct 1, 2024 · 2b223e1 · 2b223e1
1 parent 1d58b6d
commit 2b223e1
Show file tree

Hide file tree

Showing 6 changed files with 57 additions and 3 deletions.
diff --git a/docs/releases.rst b/docs/releases.rst
@@ -51,8 +51,11 @@ In verbose mode, the ``discover`` step now prints information
 about the beakerlib libraries which were fetched for the test
 execution. Use ``tmt run discover -vvv`` to see the details.
 
-``tmt try`` now supports :ref:`/stories/cli/try/option/epel` option
-backed by :ref:`prepare/feature</plugins/prepare/feature>` plugin.
+The ``tmt try`` command now supports the new
+:ref:`/stories/cli/try/option/epel` option backed by the
+:ref:`prepare/feature</plugins/prepare/feature>` plugin and the
+new :ref:`/stories/cli/try/option/install` option backed by the
+:ref:`prepare/feature</plugins/prepare/install>` plugin.
 
 
 tmt-1.36.1

diff --git a/stories/cli/try.fmf b/stories/cli/try.fmf
@@ -146,3 +146,18 @@ link:
         link:
           - implemented-by: /tmt/trying.py
           - implemented-by: /tmt/steps/prepare/feature.py
+
+    /install:
+        story:
+            As a user I want an easy way to install local rpm package on the guest.
+        description: |
+            Install local rpm package on the guest.
+
+            .. versionadded:: 1.37
+
+        example:
+            - tmt try fedora@virtual --install tree
+
+        link:
+          - implemented-by: /tmt/trying.py
+          - implemented-by: /tmt/steps/prepare/install.py
diff --git a/tests/try/basic/data/install.exp b/tests/try/basic/data/install.exp
@@ -0,0 +1,8 @@
+#!/usr/bin/expect -f
+# Try install
+
+set timeout 180
+spawn tmt try fedora@container --install tree -p /plans/basic
+expect "What do we do next?"
+send -- "q\r"
+expect eof
diff --git a/tests/try/basic/test.sh b/tests/try/basic/test.sh
@@ -34,6 +34,14 @@ rlJournalStart
         rlAssertGrep "Run .* successfully finished. Bye for now!" $rlRun_LOG
     rlPhaseEnd
 
+    rlPhaseStartTest "Install"
+        rlRun -s "./install.exp"
+        rlAssertGrep "Let's try.*/plans/basic" $rlRun_LOG
+        rlAssertGrep "cmd: rpm -q --whatprovides tree || dnf install -y  tree" $rlRun_LOG
+        rlAssertGrep "out: Installed:" $rlRun_LOG
+        rlAssertGrep "Run .* successfully finished. Bye for now!" $rlRun_LOG
+    rlPhaseEnd
+
     rlPhaseStartTest "Verbose Output"
         rlRun -s "TMT_CONFIG_DIR=$config ./verbose.exp"
         rlAssertGrep "custom-prepare" $rlRun_LOG

diff --git a/tmt/cli.py b/tmt/cli.py
@@ -1759,6 +1759,9 @@ def init(
 @option(
     "--epel", is_flag=True, default=False,
     help="Enable epel repository.")
+@option(
+    "--install", default=[], metavar="PACKAGE", multiple=True,
+    help="Install package on the guest.")
 @option(
     "-a", "--ask", is_flag=True, default=False,
     help="Just provision the guest and ask what to do next.")

diff --git a/tmt/trying.py b/tmt/trying.py
@@ -22,6 +22,7 @@
 from tmt.base import RunData
 from tmt.steps.prepare import PreparePlugin
 from tmt.steps.prepare.feature import _RawPrepareFeatureStepData
+from tmt.steps.prepare.install import _RawPrepareInstallStepData
 from tmt.utils import MetadataError, Path
 
 USER_PLAN_NAME = "/user/plan"
@@ -105,7 +106,7 @@ def __init__(
         self.tests: list[tmt.Test] = []
         self.plans: list[Plan] = []
         self.image_and_how = self.opt("image_and_how")
-        self.cli_options = ["epel"]
+        self.cli_options = ["epel", "install"]
 
         # Use the verbosity level 3 unless user explicitly requested
         # a different level on the command line
@@ -427,6 +428,22 @@ def handle_epel(self, plan: Plan) -> None:
                 plan.prepare, raw_data=data))
         plan.prepare._phases.append(phase)
 
+    def handle_install(self, plan: Plan) -> None:
+        """ Install local rpm package on the guest. """
+        packages = list(self.opt("install"))
+
+        # tmt run prepare --how install --package PACKAGE
+        data: _RawPrepareInstallStepData = {
+            "name": "tmt-try-install",
+            'how': 'install',
+            'package': packages,
+            }
+
+        phase: PreparePlugin[Any] = cast(
+            PreparePlugin[Any], PreparePlugin.delegate(
+                plan.prepare, raw_data=data))
+        plan.prepare._phases.append(phase)
+
     def go(self) -> None:
         """ Run the interactive session """