Staging to prod #270
Merged
Staging to prod #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: contact requests first draft * feat: first working version * feat: make sure user can only send one * feat: fetch mail via rpc * feat: cors * feat: cors via env * fix: typo * feat: Send via smtp directly * feat: check for not more than 3 contact requests in 24h * chore: better variable names * feat: adapt mail template
feat: tests for contact request function (#266) feat: adjust email template
* feat: check for contact request allowed * fix: status code * fix: mail template * feat: reply to
* feat: add monthly rain tables * fix: foreign key * fix: daily weather data * fix: add RLS * feat: created_at column, just to be sure * feat: function for fetching aggregated weather data * chore: formatting * feat: add parameter to limit number of returned months * fix: typo
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This can be merged to prod independently, as it does not require any Frontend changes. It will prepare the frontend to be ready for a) contact request feature and b) Gdk Stats feature. |
ff6347
requested changes
Jun 25, 2024
supabase/functions/_shared/checks.ts
Outdated
| const { data: senderData, error: senderDataError } = | ||
| await supabaseClient.auth.getUser(token); | ||
|
|
||
| console.log(senderData); |
supabase/functions/_shared/checks.ts
Outdated
| .eq("id", senderData.user.id) | ||
| .single(); | ||
|
|
||
| console.log(senderLookupData); |
supabase/functions/_shared/checks.ts
Outdated
| .not("contact_mail_id", "is", null); // only count sent emails | ||
|
|
||
| if (requestsToRecipientError) { | ||
| console.log(requestsToRecipientError); |
supabase/functions/_shared/checks.ts
Outdated
| .gt("created_at", sub(new Date(), { days: 1 }).toISOString()); | ||
|
|
||
| if (requestsOfLast24hError) { | ||
| console.log(requestsOfLast24hError); |
supabase/functions/_shared/checks.ts
Outdated
| const { data: recipientData, error: recipientDataError } = | ||
| await supabaseServiceRoleClient | ||
| .from("profiles") | ||
| .select("*") |
There was a problem hiding this comment.
Could we be more sparse which fields we select?
| import { checkIfContactRequestIsAllowed } from "../_shared/checks.ts"; | ||
| import { corsHeaders } from "../_shared/cors.ts"; | ||
|
|
||
| const SUPABASE_URL = Deno.env.get("SUPABASE_URL"); |
There was a problem hiding this comment.
No check if these vars don't exisit
There was a problem hiding this comment.
implemented loadEnvVars to check for that
| const SUPABASE_ANON_KEY = Deno.env.get("SUPABASE_ANON_KEY"); | ||
| const SUPABASE_SERVICE_ROLE_KEY = Deno.env.get("SUPABASE_SERVICE_ROLE_KEY"); | ||
|
|
||
| const handler = async (_request: Request): Promise<Response> => { |
| const SUPABASE_ANON_KEY = Deno.env.get("SUPABASE_ANON_KEY"); | ||
| const SUPABASE_SERVICE_ROLE_KEY = Deno.env.get("SUPABASE_SERVICE_ROLE_KEY"); | ||
|
|
||
| const handler = async (_request: Request): Promise<Response> => { |
There was a problem hiding this comment.
implented error handling in later commits
| const SMTP_SECURE = Deno.env.get("SMTP_SECURE") === "true"; | ||
|
|
||
| const SUPABASE_URL = Deno.env.get("SUPABASE_URL"); | ||
| const SUPABASE_ANON_KEY = Deno.env.get("SUPABASE_ANON_KEY"); |
There was a problem hiding this comment.
No checks for env existence
There was a problem hiding this comment.
implemented loadEnvVars to check for that
| contact_id uuid references auth.users(id) not null, | ||
| created_at timestamp with time zone default timezone('utc'::text, now()) not null, | ||
| contact_message text, | ||
| contact_mail_id text default null -- the resend.io ID of the sent contact mail |
There was a problem hiding this comment.
Is this resend.io thing still relevant?
* feat: first gdk stats * feat: monthly waterings * feat: mostFrequentTreeSpecies * fix: typo * chore: refactoring * fix: error handling and env * chore: comments * feat: more database functions * feat: env var existence check * feat: more distinguishable errors * fix: console.error instead of console.log for errors * chore: cleanup * fix: env variables * fix: more restrictive cors, chore: cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.