Support symbols as test ids consistently (#2758)

teamcapybara · Apr 12, 2024 · edc0397 · edc0397
1 parent 1ace1d7
commit edc0397
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lib/capybara/selector/definition/frame.rb b/lib/capybara/selector/definition/frame.rb
@@ -5,7 +5,7 @@
     xpath = XPath.descendant(:iframe).union(XPath.descendant(:frame))
     unless locator.nil?
       locator_matchers = (XPath.attr(:id) == locator.to_s) | (XPath.attr(:name) == locator.to_s)
-      locator_matchers |= XPath.attr(test_id) == locator if test_id
+      locator_matchers |= XPath.attr(test_id) == locator.to_s if test_id
       xpath = xpath[locator_matchers]
     end
     xpath[find_by_attr(:name, name)]

diff --git a/lib/capybara/selector/definition/label.rb b/lib/capybara/selector/definition/label.rb
@@ -6,7 +6,7 @@
     xpath = XPath.descendant(:label)
     unless locator.nil?
       locator_matchers = XPath.string.n.is(locator.to_s) | (XPath.attr(:id) == locator.to_s)
-      locator_matchers |= XPath.attr(test_id) == locator if test_id
+      locator_matchers |= XPath.attr(test_id) == locator.to_s if test_id
       xpath = xpath[locator_matchers]
     end
     if options.key?(:for)

diff --git a/lib/capybara/selector/definition/table.rb b/lib/capybara/selector/definition/table.rb
@@ -5,7 +5,7 @@
     xpath = XPath.descendant(:table)
     unless locator.nil?
       locator_matchers = (XPath.attr(:id) == locator.to_s) | XPath.descendant(:caption).is(locator.to_s)
-      locator_matchers |= XPath.attr(test_id) == locator if test_id
+      locator_matchers |= XPath.attr(test_id) == locator.to_s if test_id
       xpath = xpath[locator_matchers]
     end
     xpath = xpath[XPath.descendant(:caption) == caption] if caption