[FEAT/#466] 인앱 업데이트 자체 구현 #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1urrrr
force-pushed
the
feat/#466-custom-in-app-update
branch
from
5089f0c
to
2dd57c7
Compare
Marchbreeze
approved these changes
Aug 15, 2024
Comment on lines
+26
to
+33
| val updateVersion = snapshot.value.toString().toFloat() | ||
| val currentVersion = VERSION_NAME.toFloat() | ||
|
|
||
| val isLatestVersion = currentVersion >= updateVersion | ||
| _isLatestVersion.value = UiState.Success(isLatestVersion) | ||
| } | ||
| .addOnFailureListener { e -> | ||
| _isLatestVersion.value = UiState.Failure(e.toString()) |
There was a problem hiding this comment.
isLatestVersion 변수는 한번밖에 안쓰여서 변수 3개를 한번에 처리할 수 있을 것 같은데, 지금은 코드를 가독성 좋게 만드는 과정일까요?
(옐로 쌤들한테 불필요한 변수 설정 최소화하라고 배웠던 기억이 있어서 .. ㅋ ㅋ)
There was a problem hiding this comment.
넹 어떤 조건인지 써주는 느낌으로 변수 만들었슴다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
Screen_Recording_20240816_001107_Google.Play.Store.mp4
📢 To Reviewers