Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#749) 외출 엑셀 수정 #756

Merged
merged 6 commits into from
Sep 21, 2024
Merged

merge: (#749) 외출 엑셀 수정 #756

merged 6 commits into from
Sep 21, 2024

Conversation

ilyoil2
Copy link
Member

@ilyoil2 ilyoil2 commented Sep 20, 2024

작업 내용 설명

  • 일단 메서드 이름 대충 지음 나중에 수정할게요

주요 변경 사항

결과물

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@ilyoil2 ilyoil2 added the chore 사소한 변경 label Sep 20, 2024
@ilyoil2 ilyoil2 self-assigned this Sep 20, 2024
@ilyoil2 ilyoil2 linked an issue Sep 20, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 3.15%. Comparing base (50eaa8c) to head (1800873).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
.../team/aliens/dms/thirdparty/parser/ExcelAdapter.kt 0.00% 6 Missing ⚠️
...ns/dms/domain/outing/spi/vo/OutingApplicationVO.kt 0.00% 2 Missing ⚠️
...ting/usecase/ExportAllOutingApplicationsUseCase.kt 0.00% 2 Missing ⚠️
...ence/outing/OutingApplicationPersistenceAdapter.kt 0.00% 2 Missing ⚠️
...e/outing/repository/vo/QueryOutingApplicationVO.kt 0.00% 2 Missing ⚠️
...ns/dms/domain/file/service/WriteFileServiceImpl.kt 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #756      +/-   ##
============================================
- Coverage       3.16%   3.15%   -0.01%     
  Complexity        85      85              
============================================
  Files            654     654              
  Lines           9112    9121       +9     
  Branches         212     212              
============================================
  Hits             288     288              
- Misses          8815    8824       +9     
  Partials           9       9              
Flag Coverage Δ
3.15% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../dms/domain/outing/service/GetOutingServiceImpl.kt 0.00% <ø> (ø)
...ns/dms/domain/file/service/WriteFileServiceImpl.kt 0.00% <0.00%> (ø)
...ns/dms/domain/outing/spi/vo/OutingApplicationVO.kt 0.00% <0.00%> (ø)
...ting/usecase/ExportAllOutingApplicationsUseCase.kt 0.00% <0.00%> (ø)
...ence/outing/OutingApplicationPersistenceAdapter.kt 0.00% <0.00%> (ø)
...e/outing/repository/vo/QueryOutingApplicationVO.kt 0.00% <0.00%> (ø)
.../team/aliens/dms/thirdparty/parser/ExcelAdapter.kt 15.52% <0.00%> (-0.30%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50eaa8c...1800873. Read the comment docs.

Copy link

sonarcloud bot commented Sep 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ilyoil2 ilyoil2 merged commit 3596768 into develop Sep 21, 2024
3 of 4 checks passed
@ilyoil2 ilyoil2 deleted the ref/749-outing-excel branch September 21, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 사소한 변경
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

외출 액셀 내용 수정
2 participants