Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#747) 외출 제약 조건 수정 #748

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

ilyoil2
Copy link
Member

@ilyoil2 ilyoil2 commented Sep 19, 2024

작업 내용 설명

  • 당일에도 외출을 신청 가능하도록 변경

주요 변경 사항

결과물

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@ilyoil2 ilyoil2 added the chore 사소한 변경 label Sep 19, 2024
@ilyoil2 ilyoil2 self-assigned this Sep 19, 2024
@ilyoil2 ilyoil2 linked an issue Sep 19, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Sep 19, 2024

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 3.33%. Comparing base (f771f90) to head (8e3b9ac).
Report is 59 commits behind head on develop.

Files with missing lines Patch % Lines
...ms/domain/outing/service/CheckOutingServiceImpl.kt 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #748      +/-   ##
============================================
+ Coverage       3.31%   3.33%   +0.01%     
- Complexity        84      85       +1     
============================================
  Files            623     623              
  Lines           8646    8645       -1     
  Branches         211     210       -1     
============================================
+ Hits             287     288       +1     
  Misses          8348    8348              
+ Partials          11       9       -2     
Files with missing lines Coverage Δ
...ens/dms/domain/outing/model/OutingAvailableTime.kt 80.00% <ø> (+11.25%) ⬆️
...ms/domain/outing/service/CheckOutingServiceImpl.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f771f90...8e3b9ac. Read the comment docs.

@4mjeo 4mjeo merged commit e7100f4 into develop Sep 19, 2024
4 checks passed
@4mjeo 4mjeo deleted the fix/747-change-outing-validation branch September 19, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 사소한 변경
Projects
None yet
Development

Successfully merging this pull request may close these issues.

외출 제약조건 변경
3 participants