Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (#737) 캐싱 적용 #742

Merged
merged 4 commits into from
Sep 15, 2024
Merged

feat: (#737) 캐싱 적용 #742

merged 4 commits into from
Sep 15, 2024

Conversation

ilyoil2
Copy link
Member

@ilyoil2 ilyoil2 commented Sep 13, 2024

작업 내용 설명

  • studentWebAdapter 에 캐싱 적용했습니다
  • 캐시 저장소로 redis를 사용했습니다

주요 변경 사항

  • CacheConfig
    -- 캐시 설정을 모아뒀습니다
  • CustomKeyGenerator
    -- key를 메서드 명으로 생성해줌으로써 캐시의 종류를 구분해줄 수 있도록 하였습니다

추가적으로

  • 원래 CacheConfig에 상수를 넣어주려했는데 persistence에도 필요하고 presentation 계층에도 필요해서 하드코딩 했습니다
  • redis관련 dependencis가 persistence에 있어서 persistence에 cacheConfig 등을 뒀습니다
  • 캐싱 처리가 필요해보이는 도메인을 말해주시면 추가해서 올리겠습니다

결과물

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?

관련 이슈

@ilyoil2 ilyoil2 added the feat 새로운 기능을 추가 할 경우 label Sep 13, 2024
@ilyoil2 ilyoil2 self-assigned this Sep 13, 2024
@ilyoil2 ilyoil2 linked an issue Sep 13, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Sep 13, 2024

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 3.31%. Comparing base (5970a3d) to head (ae98d9e).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...otlin/team/aliens/dms/global/config/CacheConfig.kt 0.00% 19 Missing ⚠️
...eam/aliens/dms/global/config/CustomKeyGenerator.kt 0.00% 4 Missing ⚠️
...eam/aliens/dms/domain/student/StudentWebAdapter.kt 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #742      +/-   ##
============================================
- Coverage       3.32%   3.31%   -0.01%     
  Complexity        84      84              
============================================
  Files            621     623       +2     
  Lines           8623    8646      +23     
  Branches         211     211              
============================================
  Hits             287     287              
- Misses          8325    8348      +23     
  Partials          11      11              
Files with missing lines Coverage Δ
...eam/aliens/dms/domain/student/StudentWebAdapter.kt 0.00% <0.00%> (ø)
...eam/aliens/dms/global/config/CustomKeyGenerator.kt 0.00% <0.00%> (ø)
...otlin/team/aliens/dms/global/config/CacheConfig.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5970a3d...ae98d9e. Read the comment docs.

Copy link
Collaborator

@zios0707 zios0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확실히 DMS는 읽기 수행이 많은 앱이라서 도입되면 좋을 것 같습니다!

@zios0707
Copy link
Collaborator

아 MEAL 쪽도 캐싱 해주면 좋을 것 같아요!

@ilyoil2
Copy link
Member Author

ilyoil2 commented Sep 15, 2024

아 MEAL 쪽도 캐싱 해주면 좋을 것 같아요!

meal은 저희가 한 번 보내면 클라쪽에서 그걸 저장해두고 사용하고 있어서 캐싱을 사용할 필요가 없을 것 같아요!

@ilyoil2 ilyoil2 merged commit e629154 into develop Sep 15, 2024
4 checks passed
@ilyoil2 ilyoil2 deleted the feat/737-add-cache-processing branch September 15, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능을 추가 할 경우
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

학생 도메인에 캐싱 처리
3 participants