Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#527) 알림 삭제 api #528

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Conversation

rlaisqls
Copy link
Member

작업 내용 설명

  • 알림 삭제, 알림 전체 삭제 api
  • notificationService 분리

결과물

image image

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@rlaisqls rlaisqls force-pushed the feature/527-remove-notification branch from 1714ef6 to fc1bfee Compare June 20, 2023 14:37
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #528 (dd967f6) into develop (a8735bc) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #528      +/-   ##
============================================
- Coverage       1.61%   1.60%   -0.02%     
  Complexity        43      43              
============================================
  Files            516     520       +4     
  Lines           6870    6924      +54     
  Branches         148     149       +1     
============================================
  Hits             111     111              
- Misses          6757    6811      +54     
  Partials           2       2              
Impacted Files Coverage Δ
...in/notification/exception/NotificationErrorCode.kt 0.00% <0.00%> (ø)
...n/notification/exception/NotificationExceptions.kt 0.00% <0.00%> (ø)
...fication/service/CommandNotificationServiceImpl.kt 0.00% <0.00%> (ø)
...notification/service/GetNotificationServiceImpl.kt 0.00% <0.00%> (ø)
...in/notification/service/NotificationServiceImpl.kt 0.00% <0.00%> (ø)
...fication/usecase/RemoveMyAllNotificationUseCase.kt 0.00% <0.00%> (ø)
.../notification/usecase/RemoveNotificationUseCase.kt 0.00% <0.00%> (ø)
.../team/aliens/dms/global/security/SecurityConfig.kt 0.00% <0.00%> (ø)
...fication/NotificationOfPersistenceAdapterOfUser.kt 0.00% <0.00%> (ø)
.../dms/domain/notification/NotificationWebAdapter.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8735bc...dd967f6. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rlaisqls rlaisqls merged commit 7223294 into develop Jun 21, 2023
4 of 5 checks passed
@rlaisqls rlaisqls deleted the feature/527-remove-notification branch June 21, 2023 06:34
@team-aliens team-aliens deleted a comment from softpeanut Nov 6, 2023
@team-aliens team-aliens deleted a comment from softpeanut Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

알림 삭제 api
3 participants