Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge: (#523) topic 구독 설정 저장 및 조회 api #524

Merged
merged 25 commits into from
Jun 20, 2023
Merged

merge: (#523) topic 구독 설정 저장 및 조회 api #524

merged 25 commits into from
Jun 20, 2023

Conversation

rlaisqls
Copy link
Member

@rlaisqls rlaisqls commented Jun 16, 2023 •
edited
Loading

작업 내용 설명

  • 구독, 구독 취소시 설정 정보 저장 (TopicSubscribe)
  • 설정 정보 조회 api

주요 변경 사항

erd

  • 해당 topic enum에 대해 구독하는 경우에만 TopicSubscribe를 생성하여 저장
image

topic

  • topicGroup 안에 여러 topic들이 있고, topic에는 title과 description이 정의되어있음
  • 토픽이 추가 / 삭제 되었을때 앱에서 코드 변경할 필요 없이, 보여주기만 하면 됨

결과물

설정 정보 조회 api
image

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@rlaisqls rlaisqls added the feat 새로운 기능을 추가 할 경우 label Jun 16, 2023
@rlaisqls rlaisqls self-assigned this Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023 •
edited
Loading

Codecov Report

Merging #524 (45e42f9) into develop (1b87bef) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #524      +/-   ##
============================================
- Coverage       1.68%   1.64%   -0.04%     
  Complexity        43      43              
============================================
  Files            504     510       +6     
  Lines           6597    6732     +135     
  Branches         147     148       +1     
============================================
  Hits             111     111              
- Misses          6484    6619     +135     
  Partials           2       2
Impacted Files Coverage Δ
...s/domain/notification/dto/SetDeviceTokenRequest.kt 0.00% <0.00%> (ø)
...main/notification/dto/TopicSubscriptionResponse.kt 0.00% <0.00%> (ø)
...liens/dms/domain/notification/model/DeviceToken.kt 0.00% <0.00%> (ø)
...team/aliens/dms/domain/notification/model/Topic.kt 0.00% <0.00%> (ø)
...dms/domain/notification/model/TopicSubscription.kt 0.00% <0.00%> (ø)
...in/notification/service/NotificationServiceImpl.kt 0.00% <0.00%> (ø)
...ification/usecase/QueryTopicSubscriptionUseCase.kt 0.00% <0.00%> (ø)
...main/notification/usecase/SubscribeTopicUseCase.kt 0.00% <0.00%> (ø)
...in/notification/usecase/UnsubscribeTopicUseCase.kt 0.00% <0.00%> (ø)
...ication/usecase/UpdateTopicSubscriptionsUseCase.kt 0.00% <0.00%> (ø)
... and 15 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b87bef...45e42f9. Read the comment docs.

@rlaisqls rlaisqls force-pushed the feature/523-fcm-topic-setting branch from 252fda5 to ff8b4d4 Compare June 16, 2023 23:42
@rlaisqls rlaisqls force-pushed the feature/523-fcm-topic-setting branch from ff8b4d4 to bd88fc9 Compare June 16, 2023 23:44
softpeanut
softpeanut reviewed Jun 18, 2023
View reviewed changes
dms-core/src/main/kotlin/team/aliens/dms/domain/notification/dto/TopicSubscribeResponse.kt Outdated Show resolved Hide resolved
dms-core/src/main/kotlin/team/aliens/dms/domain/notification/model/Topic.kt Show resolved Hide resolved
dms-core/src/main/kotlin/team/aliens/dms/domain/notification/service/NotificationServiceImpl.kt Outdated Show resolved Hide resolved
dms-core/src/main/kotlin/team/aliens/dms/domain/notification/service/NotificationServiceImpl.kt Outdated Show resolved Hide resolved
dms-core/src/main/kotlin/team/aliens/dms/domain/notification/service/NotificationServiceImpl.kt Outdated Show resolved Hide resolved
dms-core/src/main/kotlin/team/aliens/dms/domain/notification/service/NotificationServiceImpl.kt Outdated Show resolved Hide resolved
...e/src/main/kotlin/team/aliens/dms/persistence/notification/entity/TopicSubscribeJpaEntity.kt Outdated Show resolved Hide resolved
@rlaisqls rlaisqls force-pushed the feature/523-fcm-topic-setting branch from fd199c8 to b12fb7b Compare June 18, 2023 05:50
@rlaisqls
chore: (#523) delete query 수정
c7bc56f 
영속성 컨텍스트에 없는 객체 삭제로 인한 에러 해결
@rlaisqls
chore: (#523) saveAll시 select 쿼리 묶어서 실행
671a2ca
@rlaisqls rlaisqls force-pushed the feature/523-fcm-topic-setting branch from 4094243 to 671a2ca Compare June 18, 2023 06:14
@rlaisqls rlaisqls force-pushed the feature/523-fcm-topic-setting branch from c90b522 to ce5d782 Compare June 19, 2023 00:05
@rlaisqls rlaisqls force-pushed the feature/523-fcm-topic-setting branch from ce5d782 to 0e84a51 Compare June 19, 2023 00:11
@rlaisqls rlaisqls requested a review from softpeanut June 19, 2023 22:14
softpeanut
softpeanut approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@softpeanut softpeanut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요

dms-infrastructure/src/main/resources/application.yml Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rlaisqls rlaisqls merged commit 64cd3d6 into develop Jun 20, 2023
4 of 5 checks passed
@rlaisqls rlaisqls deleted the feature/523-fcm-topic-setting branch June 20, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedsoftj1123 tedsoftj1123 tedsoftj1123 approved these changes

@softpeanut softpeanut softpeanut approved these changes

@jeongyoon05 jeongyoon05 Awaiting requested review from jeongyoon05

@alsdl0629 alsdl0629 Awaiting requested review from alsdl0629 alsdl0629 is a code owner

Assignees

@rlaisqls rlaisqls

Labels
feat 새로운 기능을 추가 할 경우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

topic 구독 설정 저장 및 조회 api
3 participants
@rlaisqls @tedsoftj1123 @softpeanut