Temporal: Update tests to account for use of year in ToTemporalMonthDay #4231
Conversation
| ); | ||
|
|
||
| const result6 = Temporal.PlainMonthDay.from({ year: 5781, month: 2, day: 30, calendar: "hebrew" }, { overflow: "constrain" }); | ||
| TemporalHelpers.assertPlainMonthDay( | ||
| result6, "M02", 29, | ||
| "if monthCode is not given, year is used to determine if calendar date exists, but reference year still correct", | ||
| "year and month determine if calendar date exists, and reference year must agree (Cheshvan 5781 has 29 days)", | ||
| 1972 | ||
| ); |
There was a problem hiding this comment.
For the Gregorian calendar and Hebrew calendar these looked good. I do not have a deep enough background on temporal to know if other calendars would be affected.
I checked a Hebrew calendar on both pr's to make sure the dates mentioned were accurate. I used this calendar to check - https://www.chabad.org/calendar/view/year.asp?tdate=1/1/2021
I am also not jewish, just trying to be a helpful force. Thanks for knocking out this work!
There was a problem hiding this comment.
LGTM, thanks. Note that tc39/proposal-temporal#2940 is not a normative PR - it's a clarification of the implementation-defined calendar stuff. When I originally wrote this test, I based it on a wrong interpretation of that implementation-defined stuff.
ptomato
force-pushed
the
temporal-gh-2940-universal-year-and-month-consistency
branch
from
9e34d1d
to
55bc412
Compare
Ref tc39/proposal-temporal#2863
Temporal PR: tc39/proposal-temporal#2940