Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unicode 16 identifier tests #4225

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Add Unicode 16 identifier tests #4225

merged 1 commit into from
Sep 12, 2024

Conversation

mathiasbynens
Copy link
Member

@mathiasbynens mathiasbynens requested a review from a team as a code owner September 12, 2024 11:50
Ms2ger
Ms2ger approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp for whenever you're ready

@mathiasbynens
Copy link
Member Author

This is ready to go. The esmeta check is failing but I believe this is expected since no engine implements Unicode 16 yet.

@ptomato
Copy link
Contributor

ptomato commented Sep 12, 2024

OK, I'll merge it then. Thanks!

@ptomato ptomato merged commit 4bdf978 into tc39:main Sep 12, 2024
7 of 8 checks passed
@mathiasbynens mathiasbynens deleted the unicode-16 branch September 13, 2024 11:20
@mathiasbynens mathiasbynens mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathiasbynens @ptomato @Ms2ger