Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link float16array tests PR #492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

link float16array tests PR #492

wants to merge 1 commit into from

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Nov 20, 2023

No description provided.

@@ -34,7 +34,7 @@ Stage 2 indicates that the committee expects these features to be developed and
| [Sync Iterator helpers][iterator-helpers] | Gus Caplan | Michael Ficarra<br />Jonathan Keslin<br />Kevin Gibbons | <sub>[iterator-helpers][iterator-helpers-tests]</sub> | <sub>[November&nbsp;2022][iterator-helpers-notes]</sub> |
| [Explicit Resource Management][resource-management] | Ron Buckton | Ron Buckton | <sub>[explicit-resource-management][resource-management-tests] | <sub>[March&nbsp;2023][resource-management-notes]</sub> |
| [ArrayBuffer transfer][arraybuffer-transfer] | Shu-yu Guo<br />Jordan Harband<br />Yagiz Nizipli | Shu-yu Guo<br />Jordan Harband<br />Yagiz Nizipli | <sub>[arraybuffer-transfer][arraybuffer-transfer-tests]</sub> | <sub>[January&nbsp;2023][arraybuffer-transfer-notes]</sub> |
| [Float16 on TypedArrays, DataView, `Math.f16round`][float16s] | Leo Balter | Leo Balter<br />Kevin Gibbons | :question: | <sub>[May&nbsp;2023][float16s-notes]</sub> |
| [Float16 on TypedArrays, DataView, `Math.f16round`][float16s] | Leo Balter | Leo Balter<br />Kevin Gibbons | N/A but [relevant PR](https://github.com/tc39/test262/pull/3849) | <sub>[May&nbsp;2023][float16s-notes]</sub> |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would it be N/A?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked PR doesn't add a feature flag. I'll follow up with more tests which add one later.

I guess "none yet" is maybe more precise?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh k got it. what about leaving the question mark, but adding like see [PR](…) or something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that's good too, no preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants