Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a base exception for all taopq exceptions. #69

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Add a base exception for all taopq exceptions. #69

merged 1 commit into from
Oct 4, 2023

Conversation

MeanSquaredError
Copy link
Contributor

This PR adds a base_error exception type from which all the other exception types (timeout_reached, network_error, sql_error) derive. This allows catching all possible taopq exceptions with a single catch block. Earlier I suggested this change in #68.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (fc080a6) 99.65% compared to head (40cef3e) 99.65%.
Report is 1 commits behind head on main.

❗ Current head 40cef3e differs from pull request most recent head 1e50ae5. Consider uploading reports for the commit 1e50ae5 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          68       68           
  Lines        2297     2297           
=======================================
  Hits         2289     2289           
  Misses          8        8           
Files Changed Coverage Δ
src/lib/pq/exception.cpp 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-frey d-frey merged commit 950c3ed into taocpp:main Oct 4, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants