Fallback for proctorlink #70
Conversation
rohansharmasitoula
requested review from
rakeshprabhu,
harish-talview,
merlano17,
manquer and
KeerthiHarish
as code owners
|
@rohansharmasitoula please don't tag me or so many people for review. |
rohansharmasitoula
removed request for
rakeshprabhu,
harish-talview,
merlano17 and
KeerthiHarish
There was a problem hiding this comment.
@rohansharmasitoula as discussed provides a resync option to the end user. Looping for all attempts will have a performance impact.
| @@ -1 +1 @@ | |||
| * @rakeshprabhu @harish-talview @merlano17 @devang1281 @manquer @KeerthiHarish | |||
| * @rakeshprabhu @harish-talview @merlano17 @devang1281 @KeerthiHarish | |||
There was a problem hiding this comment.
Removing @manquer from code owner as part of #70 (comment)
classes/local/api/tracker.php
Outdated
| $auth_payload->password = trim(get_config('quizaccess_proctor', 'proview_admin_password')); | ||
| $auth_response = self::generate_auth_token($api_base_url, $auth_payload); | ||
| $auth_token = json_decode($auth_response)->access_token; | ||
| $base_url = get_config('quizaccess_proctor', 'proview_callback_url'); |
There was a problem hiding this comment.
@rohansharmasitoula $api_base_url itself can be used here
classes/local/api/tracker.php
Outdated
| $auth_response = self::generate_auth_token($api_base_url, $auth_payload); | ||
| $auth_token = json_decode($auth_response)->access_token; | ||
| $base_url = get_config('quizaccess_proctor', 'proview_callback_url'); | ||
| $proctor_token = get_config('local_proview', 'token'); |
There was a problem hiding this comment.
@rohansharmasitoula Please trim the values taken from config
classes/local/api/tracker.php
Outdated
| } | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
@rohansharmasitoula Why are empty lines added at EOF
There was a problem hiding this comment.
removed.
classes/local/api/tracker.php
Outdated
| $context = stream_context_create($options); | ||
| $response = file_get_contents($url, false, $context); |
There was a problem hiding this comment.
@rohansharmasitoula What is the benefit of using stream_context_create and file_get_contents instead of curl here?
There was a problem hiding this comment.
Using file_get_contents seemed to be easier than Curl, was unaware about the pros of curl. Changed to curl implementation.
templates/tracker.mustache
Outdated
| if(proctor_type=='ai_proctor'||proctor_type=='record_and_review'||proctor_type=='live_proctor'){ | ||
| if(proctor_type=='ai_proctor'||proctor_type=='record_and_review'){ | ||
| external_session_id= quiz_id+'-'+user_id+'-'+attempt_no; | ||
| } | ||
| else if(proctor_type=='live_proctor'){ | ||
| external_session_id= quiz_id+'-'+user_id; | ||
| } | ||
| fetchSecureToken(external_session_id, external_attendee_id) |
There was a problem hiding this comment.
@rohansharmasitoula This can be written as a function and reused
There was a problem hiding this comment.
refactored
rohansharmasitoula
requested review from
rakeshprabhu
and removed request for
rakeshprabhu
Description
Github Issue
Checklist before requesting a review
Type of change