Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor the VSCode please command #1534

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jaresty
Copy link
Contributor

@jaresty jaresty commented Aug 10, 2024

  • I was frequently getting this triggered in the middle of other commands
  • I don't think it makes sense to chain this command

- I was frequently getting this triggered in the middle of other commands
- I don't think it makes sense to chain this command
Copy link
Collaborator

@nriley nriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the community backlog session — this now creates a difference between the VSCode and the other please implementations in community. I would recommend you consider addressing #1536 or modifying the other implementations at the same time as this one.

nriley and others added 2 commits August 10, 2024 16:21
- since jetbrains is already different, I'm not sure which way to go if I were to try and consolidate with the single overrideable helper.
- if it is preferable to come up with a single overrideable helper, I'm happy to do so but would like some guidance what to do with jetbrains
@jaresty
Copy link
Contributor Author

jaresty commented Aug 11, 2024

I'm opting to simply anchor the current please commands

  • since jetbrains is already different, I'm not sure which way to go if I were to try and consolidate with the single overrideable helper.
  • if it is preferable to come up with a single overrideable helper, I'm happy to do so but would like some guidance what to do with jetbrains

@auscompgeek
Copy link
Collaborator

auscompgeek commented Aug 11, 2024

I don't see how the JetBrains equivalent behaves any differently to the VSCode one. They both open a command palette and optionally insert some text.

meme: "Corporate needs you to find the differences between this picture and this picture." please / please "They're the same picture."

@jaresty
Copy link
Contributor Author

jaresty commented Aug 11, 2024

It behaves the same, but the naming is different. I heard that the ask was to make a single talon definition that had overridden implementations in each application. If I do that for jetbrains, users who rely on the "action" usage will not have that anymore. Is that what I should do?

@jaresty
Copy link
Contributor Author

jaresty commented Aug 11, 2024

Ok, I think I'll put together a version of this that consolidates on a single overrideable command so we can discuss/decide which works better.

@jaresty
Copy link
Contributor Author

jaresty commented Aug 11, 2024

Here is a version of this that does that: #1537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants