Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds some snap helpers to split windows to the left in various ways #1465

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jaresty
Copy link
Contributor

@jaresty jaresty commented Jun 24, 2024

No description provided.

core/windows_and_tabs/window_management.talon Outdated Show resolved Hide resolved
core/windows_and_tabs/window_management.talon Outdated Show resolved Hide resolved
core/windows_and_tabs/window_management.talon Outdated Show resolved Hide resolved
@phillco phillco self-assigned this Jun 24, 2024
@jaresty
Copy link
Contributor Author

jaresty commented Jul 6, 2024

I changed this to use the internal apis directly instead. I got rid of snap left in favor of using a custom snap split function. The snapping seems to work pretty well but sometimes the focus is not where I expect it to be. I think that's probably okay though. I think there is still value in having the snap functions available to use at any moment.

@jaresty
Copy link
Contributor Author

jaresty commented Aug 11, 2024

This seems to be working pretty well-is there anything that I'm missing that needs to be looked at?

- operates opposite of snap left
- We're concerned about using the existing names in talonscript since folks may want to remap the names
- This relies on existing internal apis instead
This consolidates the logic into a single rule in the talon file and reused keys of the existing map for readability.
@jaresty
Copy link
Contributor Author

jaresty commented Aug 22, 2024

I learned how to clean this up a bit using talon captures and talon lists. There are only two rules now for splitting with two apps or splitting with three apps. I reused the keys of the the snap window dictionary in python so that I would have some human readable names for the positions that I am snapping to. In addition I switched to window.focus() since what I really wanted was for the windows to be focused in the front on the screen. This makes it a lot more usable.

@jaresty
Copy link
Contributor Author

jaresty commented Sep 5, 2024

@phillco was I able to address your concerns? Let me know if I can switch things up to make it reasonable for you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants