Added mode indicator

[AndreasArvidsson]

Will show different colors for sleep, dictation, mixed, command/other modes

[rntz]

Looks sensible, but I need to test it and I'm away from computer atm. Probably want a default=False for the activation setting so that if the .talon file gets deleted (a thing users are supposed to be able to do) the Python file doesn't start erroring.

[pokey]

Haven't tested but looks good to me. Gradient would be nice but prob don't need it to be that fancy

[pokey]

Probably want a default=False for the activation setting so that if the .talon file gets deleted (a thing users are supposed to be able to do) the Python file doesn't start erroring.

Yeah good point. I think the standard thing here would be to use defaults for everything and then have the settings commented out in the settings file, but I think just doing that for activation setting is reasonable. Then can have a line that's commented out in the settings file that will activate it when uncommented

[AndreasArvidsson]

Probably want a default=False for the activation setting so that if the .talon file gets deleted (a thing users are supposed to be able to do) the Python file doesn't start erroring.

Yeah good point. I think the standard thing here would be to use defaults for everything and then have the settings commented out in the settings file, but I think just doing that for activation setting is reasonable. Then can have a line that's commented out in the settings file that will activate it when uncommented

Initially I had all the defaults in the python file but after a lengthy discussion with @phillco we decided that the Talon file and the python file is part of the plugin and if you don't want it you can just delete the entire folder.
There is something really nice about having all the default values in a Talon file and not having things be commented out. We could of course have all defaults in two places but we decided that if it's just going to be in one place then the Talon file is probably the best.

[phillco]

Yeah, I think having commented-out settings that duplicate the defaults in the Python file is messy, and might encourage the user to change the defaults in the Python file instead, since those are not commented out. It's also an invitation for the two sources of truth to drift over time.

I think the deletion behavior we want is to encourage plugin folders to be isolated, so that the user can delete the entire plugin without causing problems (ie there aren't references to it from outside of the plugin, as is the case with, for example, the mouse grid). That's generally the behavior we see novice users do: they see an entire folder of functionality that they don't want, and delete it, and we should try to make that possible.

(If a dependency is necessary, it should go the other way -- ie, core defines actions as extension points that are implemented by the plugin. Although I guess we would still have warnings if they were empty, hmm.)

Defaulting mode_indicator_show=False seems like a good move though.

[AndreasArvidsson]

@pokey Gradient added as per your request :D

[phillco]

If you're multiplying it by the scale factor, then these aren't necessarily pixels. For example, on my screen, this becomes a diameter of 120px.

Suggested change

	# 30pixels diameter
	# Diameter (in resolution independent points).

[AndreasArvidsson]

I'm still not sure that point is more clear to people.

[AndreasArvidsson]

@lunixbochs Looks like screen scaling is applied automatically on mac, but not on windows. Is that a bug or something that we should work with?

[nriley]

Another Mac versus Windows difference that results in inconsistent behavior in the mode indicator appears to be the corner of the window that stays fixed when resizing a canvas:

Mac:

>>> from talon.canvas import Canvas; canvas = Canvas.from_rect(Rect(0,0,0,0)); canvas.resize(20,20); canvas.rect
Rect(0.0, -20.0, 20.0, 20.0)

Windows:

>>> from talon.canvas import Canvas; canvas = Canvas.from_rect(Rect(0,0,0,0)); canvas.resize(20,20); canvas.rect
Rect(0.0, 0.0, 20.0, 20.0)

@lunixbochs — should this behavior be consistent cross-platform in core Talon or should we be accommodating it in our Python code?

@AndreasArvidsson — in the meantime you can resize then move to ensure that the indicator does not appear off the top of the screen using the default settings on Mac.

[AndreasArvidsson]

@nriley I have now updated it so it resizes before move. Please try it out again.

[phillco]

I've been running with this for a week and no longer notice any oddities with the indicator relocating after resuming/logging in from sleep, which I saw in the previous version (previously I would see it would shift up several hundred pixels out of the dock area, fixed by a Talon restart)

[phillco]

Colors look good to me.