Fix for polyglot when in lib/ext #319

cstamas · 2024-07-10T11:20:27Z

Originally polyglot worked when loaded via .mvn/extensions.xml but not when created custom distro (put in lib/ext).

Reason was simple, as Maven core beans were not overridden when in "flat space", that causes lib/ext, unlike mvn extensions.

To make it work from lib/ext (when components are placed into maven core), following is needed:

DefaultProjectBuilder is "default" bean, hence we need to override it (using priority)
DefaultModelProcessor is trickier, it uses custom name (despite class name being Default) and uses Typed annotation. Essentially same thing, using priority makes polyglot component "prevail" as otherwise they are same ranked (non-default custom named components).
finally, do not extend component but use JSR330 capability to inject "exact" bean and just compose (possible as all used methods are public on replaced bean as well).

Originally polyglot worked when loaded via .mvn/extensions.xml but not when created custom distro (put in lib/ext). Reason was simple, as Maven core beans were not overridden when in "flat space", that causes lib/ext, unlike mvn extensions.

cstamas · 2024-07-10T11:23:26Z

@headius This PR is needed to make polyglot work when created "custom Maven distro" (repackaged Maven with polyglot in lib/ext). I tested and figured it does not work with current releases. Tested with polyglot ruby, but this is polyglot-common change, not lang specific at all.

cstamas · 2024-07-10T11:56:27Z

@mkristian ping as well ^^ so my advice, creating "custom maven distro" (unpack mvn zip, put polyglot-ruby w/ deps into lib/ext, repack) will NOT work with current version (tested manually). This PR adds the change that makes it work, but also keeps original capability to work from .mvn/extensions.xml as well.

cstamas · 2024-07-10T11:56:45Z

We may want 0.7.1 release with this change.

headius · 2024-07-10T14:00:20Z

@cstamas Thanks for the ping on this one. I tried to integrate polyglot into our ruby-maven gem myself and thought I must be doing something wrong! Glad to hear that it's a pretty simple fix in polyglot. Let me know if you need my help getting this integrated and released (testing etc).

I will open a bug or reference this PR from the ruby-maven side so folks know we are moving forward with a solution.

cstamas · 2024-07-10T14:03:04Z

I can merge and do 0.7.1 asap. Ok?

headius · 2024-07-10T14:32:36Z

If you are happy with it, go ahead with release.

I can work with @mkristian this week/end to get it integrated into ruby-maven and let you know if we have any further issues.

cstamas · 2024-07-10T15:01:47Z

https://github.com/takari/polyglot-maven/releases/tag/polyglot-0.7.1

Sync to central pending...

mkristian · 2024-07-10T16:24:50Z

@cstamas cool.thanks. yes I am going to work on this integration this weekend.

laeubi · 2024-08-02T15:54:42Z

This change now likely breaks the whole .mvn/extensions.xml usecase for Tycho:

Bump io.takari.polyglot:polyglot-common from 0.7.0 to 0.7.1 eclipse-tycho/tycho#4063

org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project tycho-pomless: Compilation failure
/home/runner/work/tycho/tycho/tycho/tycho-extras/tycho-pomless/src/main/java/org/eclipse/tycho/pomless/TychoTeslaProjectBuilder.java:[30,8] constructor TeslaProjectBuilder in class org.sonatype.maven.polyglot.TeslaProjectBuilder cannot be applied to given types;
  required: org.sonatype.maven.polyglot.TeslaModelProcessor,org.apache.maven.project.DefaultProjectBuilder
  found:    no arguments
  reason: actual and formal argument lists differ in length

cstamas · 2024-08-02T16:39:00Z

See https://github.com/eclipse-tycho/tycho/blob/main/tycho-extras/tycho-pomless/src/main/java/org/eclipse/tycho/pomless/TychoTeslaModelProcessor.java#L18

laeubi · 2024-08-02T17:12:20Z

Good point :-D

Lets see if it helps:

Pr 4051 eclipse-tycho/tycho#4077

laeubi · 2024-08-03T06:36:28Z

Now it fails with

Caused by: java.lang.NullPointerException: Cannot invoke "java.util.Map.get(Object)" because "options" is null
    at org.sonatype.maven.polyglot.TeslaModelProcessor.getPomXmlFile (TeslaModelProcessor.java:159)
    at org.sonatype.maven.polyglot.TeslaModelProcessor.read (TeslaModelProcessor.java:116)
    at org.sonatype.maven.polyglot.TeslaModelProcessor.read (TeslaModelProcessor.java:97)
    at org.eclipse.tycho.packaging.UpdateConsumerPomMojo.execute (UpdateConsumerPomMojo.java:196)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:903)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:280)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:203)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:569)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:255)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:201)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:361)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:314)

cstamas · 2024-08-03T10:20:01Z

As you invoke modelProcessor with null options here:
https://github.com/eclipse-tycho/tycho/blob/e1967079439bb9dd6f3e604105cb6f5b118d1fce/tycho-packaging-plugin/src/main/java/org/eclipse/tycho/packaging/UpdateConsumerPomMojo.java#L196

Which in case polyglot is installed is invalid. Polyglot is envisioned to be "installed" or "not installed" (is Maven extension), and when installed it "takes over some key components". Am unsure what this "pomless tycho extras" is doing and why it uses Polyglot at all...

laeubi · 2024-08-04T06:10:42Z

As you invoke modelProcessor with null options here:
Which in case polyglot is installed is invalid.

Where is this documented? It obviously has worked in 0.7.0 (and previous versions) but now fails with 0.7.1

Polyglot is envisioned to be "installed" or "not installed" (is Maven extension),

Tycho is a Maven extension as well and uses (and extends) polyglot since years and actually was the reason for changes/bugfixes I proposed here over the time

Am unsure what this "pomless tycho extras" is doing and why it uses Polyglot at all...

Tycho extends Polyglot in a way that it can use Eclipse Metadata files as build input (like yaml or json or ... in this repository): https://tycho.eclipseprojects.io/doc/latest/StructuredBuild.html

laeubi · 2024-08-04T06:17:57Z

Beside that, the javadoc clearly states that null is allowed, so this is a bug of polyglot-common.

  /**
     * Reads the model from the specified file.
     *
     * @param input The file to deserialize the model from, must not be {@code null}.
     * @param options The options to use for deserialization, may be {@code null} to use the default values.
     * @return The deserialized model, never {@code null}.
     * @throws IOException If the model could not be deserialized.
     * @throws ModelParseException If the input format could not be parsed.
     */
    Model read(File input, Map<String, ?> options) throws IOException, ModelParseException;

laeubi · 2024-08-04T08:38:00Z

Passing an empty map results in

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-packaging-plugin:5.0.0-SNAPSHOT:update-consumer-pom (default-update-consumer-pom) on project bundle1: Execution default-update-consumer-pom of goal org.eclipse.tycho:tycho-packaging-plugin:5.0.0-SNAPSHOT:update-consumer-pom failed: Unable to determine model input format; options={} -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.eclipse.tycho:tycho-packaging-plugin:5.0.0-SNAPSHOT:update-consumer-pom (default-update-consumer-pom) on project bundle1: Execution default-update-consumer-pom of goal org.eclipse.tycho:tycho-packaging-plugin:5.0.0-SNAPSHOT:update-consumer-pom failed: Unable to determine model input format; options={}
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:333)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:903)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:280)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:203)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:569)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:255)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:201)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:361)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:314)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default-update-consumer-pom of goal org.eclipse.tycho:tycho-packaging-plugin:5.0.0-SNAPSHOT:update-consumer-pom failed: Unable to determine model input format; options={}
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:133)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:903)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:280)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:203)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:569)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:255)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:201)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:361)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:314)
Caused by: java.lang.RuntimeException: Unable to determine model input format; options={}
    at org.sonatype.maven.polyglot.PolyglotModelManager.getReaderFor (PolyglotModelManager.java:63)
    at org.sonatype.maven.polyglot.TeslaModelProcessor.read (TeslaModelProcessor.java:153)
    at org.sonatype.maven.polyglot.TeslaModelProcessor.read (TeslaModelProcessor.java:97)
    at org.eclipse.tycho.packaging.UpdateConsumerPomMojo.execute (UpdateConsumerPomMojo.java:199)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:903)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:280)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:203)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:569)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:255)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:201)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:361)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:314)

laeubi · 2024-08-11T15:55:36Z

@cstamas @gnodet any chance to look into this? This currently completely breaks Tycho integration and polyglot is a very important part of it.

gnodet · 2024-08-11T21:57:54Z

There's not many code changes, why is that broken ? Maybe you should raise a different issue.

laeubi · 2024-08-12T04:52:15Z

I can only tell that it worked in 0.7.0 but fails in 0.7.1 and this one looks like it is changing some fundamental things I have now created

[regression] Polyglot breaks contract of ModelReader#read #321

headius · 2024-08-29T04:26:29Z

@cstamas @mkristian I am just checking in to see how we're coming with this work and the integration into JRuby's ruby-maven gem. Let me know how I can help!

gnodet · 2024-08-29T05:23:23Z

@laeubi this issue is close, can you open a new one ? Is there a fix available yet ?

cstamas · 2024-08-29T08:48:12Z

So the timeline of events:

jruby used old maven (3.2.5?) in some docker powered builds where .mvn/extensions.xml was in docker FS root
maven in 3.5.x (or around, long time ago) updated mvn scripts that disregard root path, will not detect .mvn if in FS root
jruby project updated maven from ancient 3.2.x to 3.6.x (or even newer?) and suddenly their docker builds stopped working (as Maven disregarded .mvn/extensions.xml in FS root) -- did not load polyglot
I proposed them that for their docker build they create "custom" mvn distro with polyglot in lib/ext (example Experiment: create custom Ruby distro #323)
BUT it turned out that polyglot is NOT capable to work like it (polyglot in extension classloader -- ie loaded via .mvn/extensions.xml worked, but when in same classloader where core is, it did not work, Sisu did not pick it up, hence priorities needed)
hence I created this PR and released 0.7.1 -- this change simply makes sure in whichever classloader polyglot is (is loaded via .mvn/extensions.xml or is present in lib/ext), is active and works as expected. Polyglot was always like this: IF present, it takes over... users never loaded polyglot "by chance" or loaded and did not used it.
in the meantime Maven 3.9.9 went out that fixed initial problem: it will pick up .mvn/extensions.xml from FS root
I have no idea how and for what Tycho uses polyglot, but it seems they had it added to Maven components, and problem for them is now that polyglot becomes "active" while before it was somehow (I assume) dormant (as Sisu did not pick them up)?

cstamas · 2024-08-29T08:53:38Z

So, for JRuby: @headius @mkristian I think all your issues are resolved, and please go for Maven 3.9.9 as then you can even leave your docker images unchanged, as Maven 3.9.9 (but not any before!) will pick up .mvn/extensions.xml from FS root.

For Tycho: again, am unsure how and for what polyglot is used in there and how it worked before, given the problem is that polyglot became "active" while it was not before. So why is it in classpath then in the first place?

laeubi · 2024-08-29T09:47:26Z

For Tycho: again, am unsure how and for what polyglot is used in there and how it worked before,

Tycho is providing a polyglot implementation "since ever" (oldest one I can found is form 2015) like polyglot-yaml, or polyglot-ruby, or ... just that is is not part of the polyglot repo and released independent.

given the problem is that polyglot became "active" while it was not before. So why is it in classpath then in the first place?

I never said that anywhere so I'm confused, polyglot is and was always active for Tycho (using .mvn/extensions.xml) and that part is still working. What is no longer working is, that if polyglot is active the Maven Modelreader is broken, thats what I have described here:

[regression] Polyglot breaks contract of ModelReader#read #321

so whatever I pass (null or empty Map) the ModelReader fails to read that model as it should and worked before the micro change in version as used here (the ModelReader is used inside a Mojo!):

https://github.com/eclipse-tycho/tycho/blob/f77e3f951d99ee74d4c49f1d7e723566d767242b/tycho-packaging-plugin/src/main/java/org/eclipse/tycho/packaging/UpdateConsumerPomMojo.java#L194-L199

One special thing to consider is, that polyglot has these options:

There is a polyglot file (like, yaml, rb, ...) then the polyglot implementation is used
There is a pom.xml in wich case this takes precedence over the former and works "like before"

I can only guess that the second case is broken now somehow or there is a different ordering of calls or a missing delegation call as the message says

Unable to determine model input format; options={}

or you get a NPE

Cannot invoke "java.util.Map.get(Object)" because "options" is null

so it seems the modelreader expects a custom model in all cases.

lefou · 2024-08-30T02:10:16Z

For Tycho: again, am unsure how and for what polyglot is used in there and how it worked before,

Tycho is providing a polyglot implementation "since ever" (oldest one I can found is form 2015) like polyglot-yaml, or polyglot-ruby, or ... just that is is not part of the polyglot repo and released independent.

It's a bit unfortunate, that this never came to the attention of the polyglot maintainers. It would be good, if we add Tycho to the list polyglot dialects, even if it is maintained externally.

mkristian · 2024-08-30T06:34:14Z

I try to finalise this today or tomorrow with with done by @cstamas

mkristian · 2024-09-01T17:37:29Z

That is the change how we use all the new stuff from here: jruby/ruby-maven#11

@headius there are still errors in the test which I just discovered this minute. That was totally under my radar.

cstamas · 2024-09-06T15:33:00Z

Fix found #326
Tested with tycho and "custom ruby maven distro", both work.

Fix for polyglot when in lib/ext

e75c937

Originally polyglot worked when loaded via .mvn/extensions.xml but not when created custom distro (put in lib/ext). Reason was simple, as Maven core beans were not overridden when in "flat space", that causes lib/ext, unlike mvn extensions.

cstamas self-assigned this Jul 10, 2024

cstamas added 2 commits July 10, 2024 14:30

Compose do not inherit

6611400

Remove comment; not true anymore

6438096

headius mentioned this pull request Jul 10, 2024

Polyglot extensions not loading in all circumstances jruby/ruby-maven#9

Open

cstamas merged commit 11badb7 into master Jul 10, 2024
4 checks passed

cstamas deleted the fix-for-libext branch July 10, 2024 14:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for polyglot when in lib/ext #319

Fix for polyglot when in lib/ext #319

cstamas commented Jul 10, 2024 •

edited

Loading

cstamas commented Jul 10, 2024 •

edited

Loading

cstamas commented Jul 10, 2024

cstamas commented Jul 10, 2024

headius commented Jul 10, 2024

cstamas commented Jul 10, 2024

headius commented Jul 10, 2024

cstamas commented Jul 10, 2024 •

edited

Loading

mkristian commented Jul 10, 2024

laeubi commented Aug 2, 2024 •

edited

Loading

cstamas commented Aug 2, 2024

laeubi commented Aug 2, 2024

laeubi commented Aug 3, 2024

cstamas commented Aug 3, 2024

laeubi commented Aug 4, 2024

laeubi commented Aug 4, 2024

laeubi commented Aug 4, 2024

laeubi commented Aug 11, 2024

gnodet commented Aug 11, 2024

laeubi commented Aug 12, 2024

headius commented Aug 29, 2024

gnodet commented Aug 29, 2024

cstamas commented Aug 29, 2024 •

edited

Loading

cstamas commented Aug 29, 2024

laeubi commented Aug 29, 2024

lefou commented Aug 30, 2024

mkristian commented Aug 30, 2024 via email

mkristian commented Sep 1, 2024

cstamas commented Sep 6, 2024

Fix for polyglot when in lib/ext #319

Fix for polyglot when in lib/ext #319

Conversation

cstamas commented Jul 10, 2024 • edited Loading

cstamas commented Jul 10, 2024 • edited Loading

cstamas commented Jul 10, 2024

cstamas commented Jul 10, 2024

headius commented Jul 10, 2024

cstamas commented Jul 10, 2024

headius commented Jul 10, 2024

cstamas commented Jul 10, 2024 • edited Loading

mkristian commented Jul 10, 2024

laeubi commented Aug 2, 2024 • edited Loading

cstamas commented Aug 2, 2024

laeubi commented Aug 2, 2024

laeubi commented Aug 3, 2024

cstamas commented Aug 3, 2024

laeubi commented Aug 4, 2024

laeubi commented Aug 4, 2024

laeubi commented Aug 4, 2024

laeubi commented Aug 11, 2024

gnodet commented Aug 11, 2024

laeubi commented Aug 12, 2024

headius commented Aug 29, 2024

gnodet commented Aug 29, 2024

cstamas commented Aug 29, 2024 • edited Loading

cstamas commented Aug 29, 2024

laeubi commented Aug 29, 2024

lefou commented Aug 30, 2024

mkristian commented Aug 30, 2024 via email

mkristian commented Sep 1, 2024

cstamas commented Sep 6, 2024

cstamas commented Jul 10, 2024 •

edited

Loading

cstamas commented Jul 10, 2024 •

edited

Loading

cstamas commented Jul 10, 2024 •

edited

Loading

laeubi commented Aug 2, 2024 •

edited

Loading

cstamas commented Aug 29, 2024 •

edited

Loading