Fix ESM resolution in @tabler/icons-react
#1231
Open
+18
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently the ESM environment still resolves to CJS exports, according to AreTheTypesWrong:
Changes made
I've fixed the file extensions settings in
rollup.config
:.js
/.ts
for CJS and.mjs
/.mts
for ESM (since there's notype: module
inpackage.json
).I've also included
exports
in thepackage.json
to explicitly specify files to resolve to.Now all the environments resolve correctly: