Range rules #154
Merged
Range rules #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows matching on when the alert appeared
BuJo
commented
Nov 14, 2023
BuJo
commented
Nov 14, 2023
BuJo
commented
Nov 14, 2023
DerGeras
approved these changes
Nov 17, 2023
pkg/aggregation/aggregator.go
Outdated
| // meaning the rules are combined via `AND`. | ||
| matchCount := 0 | ||
| for a, b := range res { | ||
| if b.MatchString(a) { | ||
| for val, matcher := range matchers { |
There was a problem hiding this comment.
A bit of nitpicking, val is used as a keyword in some programming languages, which did confuse me as well while skipping over the changes at first.
Would you consider renaming the variable?
pkg/config/rule_matching.go
Outdated
| } | ||
|
|
||
| func ParseRuleMatcher(label, s string) RuleMatcher { | ||
| if strings.HasPrefix(s, "~= ") { |
There was a problem hiding this comment.
Depending on how strict you want to be here, it might be nice to use whitespaces as delimiters, instead of static prefix/startAtSymbolX. This would allow the user to i.e. align their config values.
Nice to have, being strict is fine as well.
pkg/config/rule_matching.go
Outdated
| } else if strings.HasPrefix(s, "> ") { | ||
| return newNumberMatcher(gt, s[2:]) | ||
| } else if strings.HasPrefix(s, "= ") { | ||
| if _, err := strconv.ParseFloat(s[2:], 64); err == nil { |
There was a problem hiding this comment.
I think this warrants at least a note in the documentation, that "=" on numbers is not an exact equals, but, due to the nature of floats, is an approximation.
readme, fix typo in matching rules Co-authored-by: Oliver Schmitt <[email protected]>
* Make it possible to align configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whenrule to be able to match on when the alert happened.greater thanon numerical values. SeeREADMEfor details.whatrules are now combined viaANDwith label rules.This streamlines the behaviour, making it behave like the label
rules themselves. It also makes it possible e.g. to express that
a rule matcher only applies when the alert is old.
Rule changes:
whatrules will combine asANDwith label rules.whenrules will combine withANDwith label andwhatrules.The default is to match the value in the configuration as a regular expression.
However, this can be changed by specifying an operator.
~= string: Explicitly require a regular expression to be matched= string: Require the string to exactly match> number: Require both configuration and the value in the alert to be anumerical value and that the value in the alert to be bigger than the
configured number.
This also applies to the
<,>=,<=operators.