Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mailer] add Mailtrap bridge #1338

Merged
merged 1 commit into from
Sep 18, 2024
Merged

[Mailer] add Mailtrap bridge #1338

merged 1 commit into from
Sep 18, 2024

Conversation

kbond
Copy link
Member

@kbond kbond commented Sep 13, 2024 •
edited by OskarStark
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1338/index.json
# On Windows
SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1338/index.json

  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
composer req 'symfony/mailtrap-mailer:^7.2'

  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
unset SYMFONY_ENDPOINT
# On Windows
SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@kbond kbond mentioned this pull request Sep 13, 2024
Merged
fabpot added a commit to symfony/symfony that referenced this pull request Sep 18, 2024
@fabpot
feature #58252 [Mailer] add Mailtrap bridge (kbond)
31aa837 
This PR was merged into the 7.2 branch.

Discussion
----------

[Mailer] add Mailtrap bridge

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        | n/a
| License       | MIT

This adds a new mailer bridge for [Mailtrap](https://mailtrap.io/) (their sending feature - not email testing).

### Documentation
* symfony/symfony-docs#20217

### Recipe
* symfony/recipes#1338

Commits
-------

c811ff3 [Mailer] add Mailtrap bridge
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Sep 18, 2024
@fabpot
feature #58252 [Mailer] add Mailtrap bridge (kbond)
71611e6 
This PR was merged into the 7.2 branch.

Discussion
----------

[Mailer] add Mailtrap bridge

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        | n/a
| License       | MIT

This adds a new mailer bridge for [Mailtrap](https://mailtrap.io/) (their sending feature - not email testing).

### Documentation
* symfony/symfony-docs#20217

### Recipe
* symfony/recipes#1338

Commits
-------

c811ff3d5f [Mailer] add Mailtrap bridge
@fabpot fabpot merged commit 4590420 into symfony:main Sep 18, 2024
1 of 2 checks passed
@kbond kbond deleted the feat/mailtrap-bridge branch September 18, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Needs new Package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbond @fabpot @OskarStark